Move all tests to JUnit 5

[gavlyukovskiy]

It would be nice to move all tests to JUnit 5 and maybe we can also use testcontainers to start containers on demand instead of using docker-compose on Travis.

[rjo67]

Hi, I'll take this one, if that's ok. (junit5, not the containers)

[typekpb]

Thank you, feel free to

…

On Sat, 17 Apr 2021 at 21:13, richard oates ***@***.***> wrote: Hi, I'll take this one, if that's ok. (junit5, not the containers) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#507 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD2A3A5HB56VUDGCE3CQ4TTJHMVXANCNFSM4PH7JIUA> .

[rjo67]

ok, I'll do an initial PR to migrate the majority of the tests.
Is there a restriction on using java 1.7? To migrate P6TestOptionsRepository I'd like to use lambdas (assertThrows).

The parameterised tests are not really going to be able to be migrated in their current form, afaik. It would be certainly rather ugly, at least -- the JUnit5-Parameterized is just too different. The test-setup in the base-class would have to be completely different. Therefore I think it would be just as good to leave those tests on JUnit-4 for the time being.