Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color picker doesn't change value for HEX with minor 0 #17

Closed
kuhtini opened this issue May 27, 2020 · 2 comments
Closed

Color picker doesn't change value for HEX with minor 0 #17

kuhtini opened this issue May 27, 2020 · 2 comments

Comments

@kuhtini
Copy link

kuhtini commented May 27, 2020

Hello. Thanx for a good lib.

There is an issue with updating color in HEX input. If the input value has minor 0
#0FFDAF
#012234

Conversion on line 55 will remove minor 0 and values are not equal.


conversion-example
Maybe another HEX validation can be applied.
E.g. with regexp ^[0-9a-fA-F]+$
I tried to create a pull request with 2 lines change but failed due to access issues

@kuhtini kuhtini changed the title Color picker doesn't changes value for HEX with minor 0 Color picker doesn't change value for HEX with minor 0 May 27, 2020
pIvan added a commit that referenced this issue May 27, 2020
pIvan added a commit that referenced this issue May 27, 2020
@pIvan
Copy link
Owner

pIvan commented May 27, 2020

Hi @kuhtini can you confirm how the issue is resolved?
Thanks, Ivan

@kuhtini
Copy link
Author

kuhtini commented May 28, 2020

@pIvan Thanks, It works

@kuhtini kuhtini closed this as completed May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants