Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No dot on the map #50 #83

Closed
rodri16 opened this issue Mar 3, 2023 · 4 comments
Closed

No dot on the map #50 #83

rodri16 opened this issue Mar 3, 2023 · 4 comments

Comments

@rodri16
Copy link

rodri16 commented Mar 3, 2023

No dots using Grafana v9.3.6 and Trackmap v2.1.4
@yugako
Copy link

yugako commented Apr 18, 2023

The same for me with Grafana v9.4.7

@TZECHIN6
Copy link

The document only mention it takes "lat" and "long" as Time series data, so.... how about the dot?

@pR0Ps
Copy link
Owner

pR0Ps commented May 9, 2023

The dot is rendered based on the currently hovered data point as seen in this screenshot: https://github.com/pR0Ps/grafana-trackmap-panel/blob/master/src/img/topo-crosshair.jpg

My suspicion as to why it's not showing up in newer Grafana versions is that this plugin was built using Angular and Grafana has moved on to React (see #84). They have shims in place, but I guess they're not perfect.

@rodri16
Copy link
Author

rodri16 commented Nov 10, 2023

It is possible to migrate from Angular to React but don't know how much work does it implies to you @pR0Ps
Migrate from AngularJS to React

@pR0Ps pR0Ps mentioned this issue Apr 30, 2024
Merged
pR0Ps added a commit that referenced this issue Apr 30, 2024
@pR0Ps
Rewrite as React plugin
a0925d8 
Used the recommended `npx @grafana/create-plugin@latest` to create a new
plugin and ported the code across. Most (all?) features made it across,
but this is probably a manual upgrade regardless due to setting
changes.

Fixes: #84 #87 #83 #78 #70 #56 #46 #41 #28 #14
@pR0Ps pR0Ps closed this as completed Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pR0Ps @rodri16 @yugako @TZECHIN6