Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show errors even when under threshold #70

Closed
pinglinh opened this issue Nov 6, 2018 · 5 comments
Closed

Show errors even when under threshold #70

pinglinh opened this issue Nov 6, 2018 · 5 comments

Comments

@pinglinh
Copy link

pinglinh commented Nov 6, 2018

I noticed that when errors shown are under the threshold specified, the errors no longer show. Is it possible to make an enhancement to this to add the option of showing these errors anyways? I think it will be good in terms of trying to improve and get rid of these errors before pushing the code to build in our CI pipelines.

@42tte
Copy link
Contributor

42tte commented Feb 16, 2020

Duplicate of #54

@dapenguin
Copy link

Had a similar issue last week, but realised it was down to how I was configuring pa11y. I was setting threshold inside my .pa11yci.json file, and so when the errors were below that threshold it wouldn't output what the errors were. However, if I removed the threshold from there and used the -T flag in the CLI, that would still report the errors even if they fell below the threshold.

Don't know if that helps at all.

@I-Valchev
Copy link

@42tte hey, I'm bumping into the same issue. It appears the -T or --threshold don't work at all?

@I-Valchev
Copy link

I-Valchev commented Jan 11, 2021

hi @42tte ,

You asked if I would try this: pa11y-ci --threshold 83 --config tests/a11y/pa11yci.json

But unfortunately it doesn't work. I much prefer an option in the command line rather than the config, because that way I can use the config for CI (where I don't want it to fail for the number of existing issues, but I'd like it to fail if new ones come up) wheres I want to use that same config locally to look at all the issues (so no threshold).

Is that not possible at the moment? Thanks!

@danyalaytekin
Copy link
Member

Thanks all, and for the pointer to #54 @42tte. Let's track this there.

@danyalaytekin danyalaytekin closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants