use https where possible #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyciechanowicz
approved these changes
Oct 30, 2021
|
It seems there might be a problem with the 3 checkout_and_test CI steps. Is there anything I can do to help them to work properly? |
|
No idea what happened with the tests, I'm assuming GitHub glitched. The PR looks fine so I'm merging it anyway. Thanks @greggles! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few urls use http when they could use https. I also updated the license to point to where that URL redirects.
None of this is super necessary, but a small step toward more security seems worthwhile. Might as well use the better protocol from the beginning if possible.