Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom default headers to sitemap query #183

Closed
wants to merge 1 commit into from
Closed

Add custom default headers to sitemap query #183

wants to merge 1 commit into from

Conversation

mod-flux
Copy link

@mod-flux mod-flux commented Apr 27, 2022

Add any default headers provided in .pallyci.js to the sitemap query.

Particularly useful if you're using headers to set secure cookies in order to pass authentication checks necessary to access the sitemap (e.g. secure test environments).

Open to feedback on whether this will function the same way as pa11y uses it for running the tests.

@mod-flux mod-flux marked this pull request as draft April 28, 2022 08:54
@mod-flux mod-flux marked this pull request as ready for review April 28, 2022 10:03
@mod-flux
Copy link
Author

mod-flux commented Aug 2, 2022

Just bumping this!

Copy link
Member

@joeyciechanowicz joeyciechanowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just needs a test for the positive case and for when there are no default headers

@mod-flux mod-flux closed this by deleting the head repository Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants