Ignore config urls when using sitemap #230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
Thanks for this contribution @mkotamies! I confess I forgot it was a partner to the issue you raised, before I started working on adding a test tonight 🤦🏻♂️ I'll add you as a coauthor to those commits (if you'd like to be removed as co-author though for any reason please let me know). I've just reread @aarongoldenthal's extra findings as well, so I realise we could go quite a bit further with these tests, but for now will focus on clarifying "they combine" or "they don't combine". |
|
Work continuing in: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug report about the problem.
Readme states that
Providing a sitemap will cause the urls property in your JSON config to be ignored.but the code doesn't work as expected.I have prepared a change that sets config urls to empty array when sitemap is provided. Change includes also a test case that was missing before.