Pa11y-ci 2.x #34
Merged
Pa11y-ci 2.x #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update to use pa11y 5 beta and async/await * Correct package version to alpha version, update linting package * Remove filtering of non-errors as pa11y 5 no longer returns them by default
* Update Pa11y dependency from beta to 5.0.0 * Update navigation failure message from puppeteer and increase integration test timeout
* Update supported Node.js version documentation, replace verifyPage for screenCapture * Update README with support and migration section * Add Migration Guide
|
I've tested this and it seems to work fine :) What's missing for a merge & release? |
|
Just waiting for this: #47 (I just noticed there have been changes so going to review/catch up with Andrew now) |
* Share browser instances across test runs where possible * Simplify browser sharing to single instance using default chromeLaunchConfig only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains all the work for Pa11y-ci 2.x which includes:
All of the code in this PR has been reviewed already in separate PRs.