Capture Screen Per URL in a sitemap #74
Conversation
The screenCapture should be set under defaults array when a sitemap is used. The value should contain "filename" and It will be raplaced with a string created from url
/home/travis/build/pa11y/pa11y-ci/bin/pa11y-ci.js 200:5 error Expected indentation of 1 tab but found 4 spaces indent 200:21 error Strings must use singlequote quotes 200:32 error Strings must use singlequote quotes 200:42 error Strings must use singlequote quotes 200:55 error Strings must use singlequote quotes 200:60 error Strings must use singlequote quotes 200:72 error Strings must use singlequote quotes 200:77 error Strings must use singlequote quotes
200:5 error Expected indentation of 1 tab but found 4 spaces indent
joeyciechanowicz
added
the
status: work required
Use default config.screenCapture value for the urls in config.urls array also
cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
By the way, I did not add the unit-test yet. |
|
Can this also be used for for a list of urls? for example: In stead of specfying for each URL a screenCapture url. |
@Mschuddings I do not remember what I did for this MR :) |
|
Is there a chance that this PR will be merged? |
|
Hi @kramar, thanks for following up! Sooo reading through this conversation, it looks like the team approved the general idea, but we'll need some test coverage first. From my own point of view I'm not sure we need |
|
This is an issue for a project that I am working on. We currently use sitemap.xml and would like artifacts from every page scanned. However, the current logic of the application using a JSON config file makes it so that every screenshot is saved to the same file name when an action is run. Is there any work that can be done on this to get this PR across the finish line? |
|
@btabaska 5 years ago I have created the PR but I don know why I could not finalize it. Now, I am not able to write the tests and finalize it. @joeyciechanowicz Is it possible for you to take action on this PR? |
The "screenCapture" option should be set under "config.defaults" array when a sitemap is used.
The value should contain "filename" and It will be replaced with a string created from URL.
Closes #72