Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new HTML CodeSniffer npm package #382

Closed
rowanmanning opened this issue Feb 14, 2018 · 3 comments
Closed

Use the new HTML CodeSniffer npm package #382

rowanmanning opened this issue Feb 14, 2018 · 3 comments

Comments

@rowanmanning
Copy link
Member

We should be able to use this rather than building via Make. It'd be nice if HTMLCS was just another dependency in package.json.

https://www.npmjs.com/package/html_codesniffer

@rowanmanning rowanmanning added this to the 5.0 milestone Feb 14, 2018
@rowanmanning
Copy link
Member Author

This won't be possible currently, as the npm package for HTMLCS doesn't include the bundled JavaScript. I might either speak to the maintainers about adding it as a postinstall or prepublish step. For now I'm going to remove from the 5.0 milestone

@rowanmanning rowanmanning removed this from the 5.0 milestone Feb 14, 2018
@paazmaya
Copy link
Contributor

I am working on making this possible, squizlabs/HTML_CodeSniffer#240

@josebolos
Copy link
Member

josebolos commented Jul 16, 2019

This was been addressed as part of version 5.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants