Allow more standards. Do not hardcode the list #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, makes a lot of sense. One thing I'm not sure on is the naming of the new option. What do you think of |
|
@rowanmanning Agree. |
Hywan
force-pushed
the
relax_standards
branch
from
356c223
to
a4ab830
Compare
|
@rowanmanning Rebased and pushed! |
|
Why is it failing? |
|
It's not failing, it's just Coveralls being weird:
Thanks! |
rowanmanning
added a commit
that referenced
this pull request
Feb 1, 2016
Allow more standards. Do not hardcode the list
|
\o/ |
Hywan
added a commit
to Hywan/TheA11yMachine
that referenced
this pull request
Sep 13, 2016
Our PR pa11y/pa11y#124 has been merged and released. Our PR squizlabs/HTML_CodeSniffer#151 has been merged but not yet released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary when we add our own standards and would like to use them. This is not a feature, this is kind of a bug fix :-).
Cheers!