Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add POSSITEM source and credits, fix Demon Rifle altfire CTD bug #442

Merged
merged 23 commits into from Aug 7, 2020

Conversation

Cacodemon345
Copy link
Collaborator

@Cacodemon345 Cacodemon345 commented Jul 30, 2020

Also fixes a couple of other bugs.

@Cacodemon345 Cacodemon345 linked an issue Jul 30, 2020 that may be closed by this pull request
@Cacodemon345 Cacodemon345 linked an issue Jul 30, 2020 that may be closed by this pull request
@Cacodemon345 Cacodemon345 linked an issue Jul 31, 2020 that may be closed by this pull request
…aring when lost souls touch them if they haven't seen yet
@Cacodemon345 Cacodemon345 linked an issue Jul 31, 2020 that may be closed by this pull request
@Cacodemon345 Cacodemon345 linked an issue Aug 2, 2020 that may be closed by this pull request
@Cacodemon345 Cacodemon345 linked an issue Aug 2, 2020 that may be closed by this pull request
@JMartinezHarmoniousPerson
Copy link
Contributor

Bug report: Although the Demon Tech Rifle crash bug on overhauled enemies is fixed, however, where they're in possession state, shooting the Demon Tech Rifle will crash the game. I have got no crash log from it. Other weapons don't cause this.

@JMartinezHarmoniousPerson
Copy link
Contributor

JMartinezHarmoniousPerson commented Aug 3, 2020

Update: It seems that other weapons are crashing as well when an overhauled enemy is at possession state. I'm wondering if this is related to the zombie_man_friendly actor too, as it seems to crash firing a weapon with that actor spawned too. Unless it's because of another infinite recursion from the possession state

No crash log as well

@Cacodemon345
Copy link
Collaborator Author

I frankly got no idea how to fix it properly.

@Cacodemon345
Copy link
Collaborator Author

I fixed it finally.

Fix crashes when shooting weapons with a possessed enemy nearby
Applied the Hell Rifle crash fix for the Labguys as well, fix by Cacodemon345
- Nailgun should now properly display the correct sprite when there is no ammo left in the reserve
- Fixed the reload without reserve ammo bug with the javelin mode
@JMartinezHarmoniousPerson
Copy link
Contributor

JMartinezHarmoniousPerson commented Aug 6, 2020

Hey Cacodemon, have you checked my pull request to this PR yet? I have fixed several bugs in there and applied your Demon Tech Rifle crash bug fix to the Labguys (Labguys had their own void A_SmartChase() call due to them being a melee enemy).

Fixed unloading for single DMR
pa1nki113r
pa1nki113r previously approved these changes Aug 7, 2020
Copy link
Owner

@pa1nki113r pa1nki113r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. STRailgun has been renamed and revamped to just Railgun, other than that PBRifle and HMG have tiny conflicts that should be real quick to fix and it can be merged. Thanks for the life saving crash fix :)

@pa1nki113r pa1nki113r merged commit 7d0d7e4 into master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants