Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add Continuous Integration #3

Merged
merged 3 commits into from
Oct 28, 2022
Merged

Conversation

flemzord
Copy link
Contributor

@flemzord flemzord commented Oct 26, 2022

馃崳 Context / problem
There is no Continuous Integration yet. It is a software development good practice.

馃幆 Idea / solution
Using GitHub Actions (with CodeQL integration) to automatically run testing, linting, scanning, vulnerability checking, etc.

馃挕 Discussion / consequences
Each time a commit is pushed on a branch, then some automated checks are executed.

馃 Tests / checks
Check that GitHub Checks are displayed and executed

@flemzord flemzord marked this pull request as ready for review October 26, 2022 21:25
@flemzord flemzord mentioned this pull request Oct 26, 2022
@jbuget
Copy link
Contributor

jbuget commented Oct 27, 2022

Thanks a lot @flemzord for the PR 馃檹

Can you refine the title and add a description to the PR, something like :

Suggestion of title : "ci: Add Continuous Integration"

Suggestion of description :

馃崳 Context / problem

There is no Continuous Integration yet. It is a software development good practice.

馃幆 Idea / solution

Using GitHub Actions (with CodeQL integration) to automatically run testing, linting, scanning, vulnerability checking, etc.

馃挕 Discussion / consequences

Each time a commit is pushed on a branch, then some automated checks are executed.

馃 Tests / checks

Check that GitHub Checks are displayed and executed

Copy link
Contributor

@jbuget jbuget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃殌 Code is ok. I just wait for answers to my 2 minor questions before merging

.github/workflows/main.yaml Outdated Show resolved Hide resolved
pull_request:
branches: [main]
schedule:
- cron: '35 21 * * 5'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: why this cron value (each friday at 21h35) ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an why on each pull_request is not enough ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL is quite slow, and relies on CVEs.
You can spin it more often, but I'm not sure it's really more comfortable.

Ditto for running it on all the PRs, this is possible

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃檹 Thank you for all @flemzord . I did not know CodeQL. Very interesting. I merge.

PS : instead of CVEs, you meant CWEs (Common Weakness Enumeration), right ?

Co-authored-by: J茅r茅my Buget <265963+jbuget@users.noreply.github.com>
@flemzord flemzord changed the title ci: Add ci: Add Continuous Integration Oct 28, 2022
@jbuget jbuget merged commit 1b61a34 into paastis:main Oct 28, 2022
@flemzord flemzord deleted the feat/add-ci branch October 28, 2022 18:04
@jbuget jbuget mentioned this pull request Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants