Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad capitalization in place names starting with non-ASCII characters #21

Closed
PabloAsencio opened this issue Dec 30, 2020 · 0 comments · Fixed by #25
Closed

Bad capitalization in place names starting with non-ASCII characters #21

PabloAsencio opened this issue Dec 30, 2020 · 0 comments · Fixed by #25
Labels
bug Something isn't working

Comments

@PabloAsencio
Copy link
Owner

Place names starting with non-ASCII characters will show a capital letter in the second or third position. E.g. ŁóDź instead of the correct Łódź or İZmir instead of İzmir.
@PabloAsencio PabloAsencio added the bug Something isn't working label Dec 30, 2020
PabloAsencio added a commit that referenced this issue Dec 31, 2020
@PabloAsencio
fix: Fix problem with capitalization of names with non-ASCII characters
938220c 
The regular expression used in the capitalize function of cities-api.js
matched only ASCII characters, causing the second or third letter of a
place name to be capitalized if the first one was a Latin extended character.
Now the regular expression matches all Latin extended letters.

Solves #21
@PabloAsencio PabloAsencio linked a pull request Dec 31, 2020 that will close this issue
Fix several bugs #25
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix several bugs PabloAsencio/travel-app
1 participant
@PabloAsencio