Fix issue with crash due to bad transaction file #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablobaxter
added a commit
that referenced
this pull request
Aug 24, 2021
* Fix for persistent OOM crashing issue (cherry picked from commit 4874d79) * Added unit test and logging for OOM issue (cherry picked from commit 8d4c475) * Fix issue with crash due to bad transaction file (#36) * Fix for persistent OOM crashing issue (cherry picked from commit 4874d79) * Added unit test and logging for OOM issue (cherry picked from commit 8d4c475) * Update all libraries, roll version * Update to AGP 7 and update other gradle plugins
pablobaxter
added a commit
that referenced
this pull request
Oct 10, 2021
* Fix for persistent OOM crashing issue (cherry picked from commit 4874d79) * Added unit test and logging for OOM issue (cherry picked from commit 8d4c475) * Fix issue with crash due to bad transaction file (#36) * Fix for persistent OOM crashing issue (cherry picked from commit 4874d79) * Added unit test and logging for OOM issue (cherry picked from commit 8d4c475) * Update all libraries, roll version * Update to AGP 7 and update other gradle plugins * Use LG device for testing Harmony * Use proper model name * Create test to replicate issue with LG * Check for info on what is available for LG devices * Remove testing run * Potential fix for LG device crashes * Clean up code, testing negative case * Revert negative test case * Fix test upload * Update test dependencies * Fix issue where FileObserver thread my not be started yet * Improve on FileObserver thread start * Rename some lock objects, ensure FileObserver is initialized immediately * Revert some changes, cleanup * More cleanup * Test negative case again * Reset back to normal test case
pablobaxter
added a commit
that referenced
this pull request
Oct 10, 2021
* Fix for persistent OOM crashing issue (cherry picked from commit 4874d79) * Added unit test and logging for OOM issue (cherry picked from commit 8d4c475) * Fix issue with crash due to bad transaction file (#36) * Fix for persistent OOM crashing issue (cherry picked from commit 4874d79) * Added unit test and logging for OOM issue (cherry picked from commit 8d4c475) * Update all libraries, roll version * Update to AGP 7 and update other gradle plugins * Use LG device for testing Harmony * Use proper model name * Create test to replicate issue with LG * Check for info on what is available for LG devices * Remove testing run * Potential fix for LG device crashes * Clean up code, testing negative case * Revert negative test case * Fix test upload * Update test dependencies * Fix issue where FileObserver thread my not be started yet * Improve on FileObserver thread start * Rename some lock objects, ensure FileObserver is initialized immediately * Revert some changes, cleanup * More cleanup * Test negative case again * Reset back to normal test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clears the transaction file created due to #22, and reported in #34.
This fixes commit history due to mistaken merge into main.