Support other distance types apart from float #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found the issue. The optimized hamming distance that use SIMD instruction actually returns signed int value despite having u64 suffix in name: Can you change to integer value or cast properly within here 🙇 |
this avoids type conversion for discrete metrics like hamming
Dobatymo
force-pushed
the
generic-typing
branch
from
883ae9f
to
9eca9f7
Compare
|
@pablocael please check again. The tests are all succeeding now. https://github.com/Dobatymo/pyvptree/actions/runs/5747995002 |
pablocael
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this avoids type conversion for discrete metrics like hamming. Currently the tests fail.