Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat added bk tree benchmark and docs #51

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Conversation

pablocael
Copy link
Owner

No description provided.

@Dobatymo
Copy link
Collaborator

Dobatymo commented Oct 9, 2023

The scaling behaviour of the Faiss index looks a bit strange. Maybe can you run the benchmark again and regenerate the plot?

@pablocael
Copy link
Owner Author

The scaling behaviour of the Faiss index looks a bit strange. Maybe can you run the benchmark again and regenerate the plot?

Yes, its a bit weird. Btw it seems bktree tests failed:

         indices, distances, keys = tree.find_threshold(data, 0)
  >       assert indices == [[i] for i in range(num_points)]
  E       assert [[0, 1], [0, 1]] == [[0], [1]]
  E         At index 0 diff: [0, 1] != [0]
  E         Use -v to get more diff
  
  bktree_cls = <class '_pynear.BKTreeBinaryIndex'>
  data       = array([[233],
         [233]], dtype=uint8)
  dimensions = 1
  distances  = [[0, 0], [0, 0]]
  indices    = [[0, 1], [0, 1]]
  keys       = [[[233], [233]], [[233], [233]]]
  num_points = 2
  tree       = <_pynear.BKTreeBinaryIndex object at 0x7f7c2b26d230>

Only under ubuntu. But it is probably because I had removed fixed seeds?

@Dobatymo
Copy link
Collaborator

Dobatymo commented Oct 9, 2023

Retrying fixed it... although I am not sure why it failed before... again...

@pablocael pablocael merged commit 761e2bc into main Jan 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants