Skip to content

Commit

Permalink
pythongh-111380: Show SyntaxWarnings only once when parsing if invali…
Browse files Browse the repository at this point in the history
…d syntax is encouintered
  • Loading branch information
pablogsal committed Oct 27, 2023
1 parent 78e6d72 commit 8b46f58
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 0 deletions.
12 changes: 12 additions & 0 deletions Lib/test/test_string_literals.py
Expand Up @@ -131,6 +131,18 @@ def test_eval_str_invalid_escape(self):
self.assertEqual(exc.lineno, 1)
self.assertEqual(exc.offset, 1)

# Check that the warning is raised ony once if there are syntax errors

with warnings.catch_warnings(record=True) as w:
warnings.simplefilter('always', category=SyntaxWarning)
with self.assertRaises(SyntaxError) as cm:
eval("'\\e' $")
exc = cm.exception
self.assertEqual(len(w), 1)
self.assertEqual(w[0].category, SyntaxWarning)
self.assertRegex(str(w[0].message), 'invalid escape sequence')
self.assertEqual(w[0].filename, '<string>')

def test_eval_str_invalid_octal_escape(self):
for i in range(0o400, 0o1000):
with self.assertWarns(SyntaxWarning):
Expand Down
@@ -0,0 +1,2 @@
Fix a bug that was causing :exc:`SyntaxWarning` to appear twice when parsing
if invalid syntax is encountered later. Patch by Pablo galindo
5 changes: 5 additions & 0 deletions Parser/string_parser.c
Expand Up @@ -13,6 +13,11 @@
static int
warn_invalid_escape_sequence(Parser *p, const char *first_invalid_escape, Token *t)
{
if (p->call_invalid_rules) {
// Do not report warnings if we are in the second pass of the parser
// to avoid showing the warning twice.
return 0;
}
unsigned char c = *first_invalid_escape;
if ((t->type == FSTRING_MIDDLE || t->type == FSTRING_END) && (c == '{' || c == '}')) {
// in this case the tokenizer has already emitted a warning,
Expand Down

0 comments on commit 8b46f58

Please sign in to comment.