Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow fetch_model to check for model presence before querying DB #5

Merged
merged 1 commit into from Aug 10, 2017
Merged

Allow fetch_model to check for model presence before querying DB #5

merged 1 commit into from Aug 10, 2017

Conversation

pabloh
Copy link
Owner

@pabloh pabloh commented Aug 10, 2017 •
edited

  • When using sequel_models plugin, don't fetch the DB if the model is already loaded in context.
  • Improve plugin tests

@pabloh pabloh requested a review from roupen August 10, 2017 08:34
@pabloh
Copy link
Owner Author

pabloh commented Aug 10, 2017 •
edited

@roupen, I thought about what we talked on slack, are you ok with this change?.

@pabloh pabloh merged commit ad0c02b into master Aug 10, 2017
@pabloh pabloh deleted the fetch_model_from_context branch August 10, 2017 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roupen roupen Awaiting requested review from roupen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@pabloh