Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.0 Tasks & Enhancements #48

Closed
pablojim opened this issue Dec 1, 2013 · 3 comments
Closed

Release 1.0.0 Tasks & Enhancements #48

pablojim opened this issue Dec 1, 2013 · 3 comments

Comments

@pablojim
Copy link
Owner

pablojim commented Dec 1, 2013

I've recently added a build process. This should help add us add tests and keep the coding style consistent.

I'd like to make a release 1.0.0 over the next few weeks and this is a placeholder issue for what should be in it. Add your thoughts in the comments.

  • Add tests for initialisation
  • Add test to make sure chart update methods are only called when needed. Currently they are called more than is needed
  • Prioritise existing issues for resolution

Other possibilities:

  • Change the attribute binding to use expressions?
  • Move the more dynamic parts of config into their own attributes. e.g.
    <highchart options="options" series="series" loading="hasLoaded"/>

Any others? What else could be improved?

@pablojim
Copy link
Owner Author

pablojim commented Dec 1, 2013

@kristerkari @r3m0t @amaurydecreme Any thoughts?

@kristerkari
Copy link
Contributor

@pablojim Thanks for asking.

👍 for tests. For other stuff: I'm quite happy with the current implementation, so nothing specific comes to mind.

@amaury-d
Copy link
Contributor

amaury-d commented Dec 4, 2013

@pablojim https://github.com/pablojim Thanks for asking, same here,
everything looks fine

On Mon, Dec 2, 2013 at 8:34 AM, Krister Kari notifications@github.comwrote:

@pablojim https://github.com/pablojim Thanks for asking.

[image: 👍] for tests. For other stuff: I'm quite happy with the
current implementation, so nothing specific comes to mind.


Reply to this email directly or view it on GitHubhttps://github.com//issues/48#issuecomment-29599170
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants