Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update en Nginx Ingress Controller #214

Merged
merged 3 commits into from May 24, 2022
Merged

Conversation

chanix95
Copy link
Contributor

Hola Pelado,
Primero que todo, gracias por tanto!

Intenté seguir el video y encontré un par de errores. Actualicé los manifiestos, me parece que había un par de cosas deprecadas.

Fix: builtin Secret type kubernetes.io/tls

Error trying to get the default server TLS secret nginx-ingress/default-server-secret: nginx-ingress/default-server-secret is invalid: TLS Secret must be of the type kubernetes.io/tls

Referencias: kubernetes docs, Ejemplo del repo Nginx Ingress Controller, Guia de instalación de NGINX Ingress Controller

Fix: IngressClass resource

Error when getting IngressClass nginx: ingressclasses.networking.k8s.io "nginx" not found

Referencias: kubernetes docs, Guia de instalación de NGINX Ingress Controller, Ejemplo del repo Nginx Ingress Controller

Resolves #182

@gitguardian
Copy link

gitguardian bot commented May 22, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- RSA Private Key 2036019 kubernetes/8/ingress/02-default-server-secret.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@gmarcos87
Copy link

Gracias @chanix95 esto soluciona el problema. Y gracias @pablokbs por compartir todo esto.

Copy link
Owner

@pablokbs pablokbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias!

@pablokbs pablokbs merged commit 2c5547b into pablokbs:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pod en estado CrashLoopBackOff
3 participants