Develop (#50)

* Handle JSON.parse errors

* Handle Grado SyS 2024

* v6.3.9

js/guarani/DataCollector.js

@@ -45,6 +45,7 @@ UtnBaHelper.DataCollector = function (store, pagesDataParser, apiConnector) {
 				},
 			];
 
+			let shouldSaveLastTimeCollected = false;
 			let promise = Promise.resolve();
 			collectMethods.filter(collectMethod => {
 				// Never collected or min time has passed.
@@ -53,12 +54,16 @@ UtnBaHelper.DataCollector = function (store, pagesDataParser, apiConnector) {
 				promise = promise.then(() => {
 					return collectMethod.method();
 				}).then(() => {
+					// If at least one collect method is executed, we need to save the last time collected info to local storage.
+					shouldSaveLastTimeCollected = true;
 					lastTimeCollected[collectMethod.key] = Date.now();
 				});
 			});
 
 			return promise.then(() => {
-				saveLastTimeCollected(hashedStudentId, lastTimeCollected);
+				if (shouldSaveLastTimeCollected) {
+					saveLastTimeCollected(hashedStudentId, lastTimeCollected);
+				}
 			});
 		});
 	};
@@ -78,7 +83,13 @@ UtnBaHelper.DataCollector = function (store, pagesDataParser, apiConnector) {
 	// -----
 
 	let getLastTimeCollectedByHashedStudentId = function () {
-		let lastTimeCollectedByHashedStudentId = JSON.parse(localStorage.getItem(LOCAL_STORAGE_DATA_COLLECTOR_KEY));
+		let lastTimeCollectedByHashedStudentId;
+		try {
+			// Don't know why, but some cases were failing with json parsing errors... We simply consider those as not present.
+			lastTimeCollectedByHashedStudentId = JSON.parse(localStorage.getItem(LOCAL_STORAGE_DATA_COLLECTOR_KEY));
+		} catch (e) {
+			console.error(`Error parsing localStorage item...`, e);
+		}
 		if (!lastTimeCollectedByHashedStudentId) {
 			lastTimeCollectedByHashedStudentId = {};
 			localStorage.setItem(LOCAL_STORAGE_DATA_COLLECTOR_KEY, JSON.stringify(lastTimeCollectedByHashedStudentId));

js/guarani/PagesDataParser.js

@@ -264,7 +264,9 @@ UtnBaHelper.PagesDataParser = function (utils) {
 			"Anual": "A",
 			"Primer Cuatrimestre": "1C",
 			"Segundo Cuatrimestre": "2C",
-			"ASS": "A", // Weird case, was found in "Grado ASS 2022" (seems to be specific to courseCode: 950454)
+			// Weird cases, was found in "Grado ASS 2022", and "Grado SyS 2024" (seems to be specific to courseCode: 950454 -> "Análisis de Señales y Sistemas")
+			"ASS": "A",
+			"SyS": "A",
 		};
 		const yearAndQuarterRegex = new RegExp(`^Grado (${Object.keys(quarterTxtMapping).join("|")}) (\\d{4})$`);
 		let groups = yearAndQuarterRegex.exec(periodTxt);

manifest.json

@@ -2,7 +2,7 @@
   "manifest_version": 3,
   "name": "UTN.BA Helper (ex Siga Helper)",
   "short_name": "UTN.BA Helper",
-  "version": "6.3.8",
+  "version": "6.3.9",
   "description": "UTN.BA Helper facilita el uso de la web de la UTN - FRBA.",
   "author": "Pablo Matías Gomez",
   "icons": {