Remove bloch(h, ϕs...), leave only bloch(h, ϕs) #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
+ Coverage 36.69% 37.06% +0.36%
==========================================
Files 14 14
Lines 2101 2083 -18
==========================================
+ Hits 771 772 +1
+ Misses 1330 1311 -19
Continue to review full report at Codecov.
|
4 tasks
pablosanjose
added a commit
that referenced
this pull request
Apr 12, 2020
pablosanjose
added a commit
that referenced
this pull request
Apr 12, 2020
This reverts commit a4f2e68.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leave only the
bloch(h, ϕs)/bloch!(matrix, h, ϕs)syntax to obtain the Bloch Hamiltonian ofh. Thebloch(h)syntax for the unit cell Hamiltonian remains. However theh(ϕs)andh(ϕs...)forms are also removed.