fix: adapt link component to local routes (#8)

pablosirera · Oct 21, 2020 · 0bb5ac5 · 0bb5ac5
1 parent b429351
commit 0bb5ac5
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 3 deletions.
diff --git a/components/global/TheLink.vue b/components/global/TheLink.vue
@@ -1,5 +1,5 @@
 <template>
-  <a class="link" target="_blank" :href="url">
+  <a class="link cursor-pointer" @click="goToUrl">
     <slot />
   </a>
 </template>
@@ -12,6 +12,20 @@ export default {
       type: String,
       required: true,
     },
+    isLocalRoute: {
+      type: Boolean,
+      default: false,
+    },
+  },
+  methods: {
+    goToUrl() {
+      if (this.isLocalRoute) {
+        this.$router.push(this.url)
+        return
+      }
+
+      window.open(this.url, '_blank')
+    },
   },
 }
 </script>

diff --git a/pages/about/index.vue b/pages/about/index.vue
@@ -12,7 +12,9 @@
     </p>
     <p>
       <!-- TODO: add link to blog -->
-      De vez en cuando escribo artículos en mi blog, hago directos en
+      De vez en cuando escribo artículos en mi
+      <TheLink :is-local-route="true" url="/blog">blog</TheLink>, hago directos
+      en
       <TheLink url="https://twitch.tv/pablosirera">Twitch</TheLink> aprendiendo
       en vivo o subo vídeos a
       <TheLink url="https://youtube.com/psirera4?sub_confirmation=1">

diff --git a/pages/blog/_slug.vue b/pages/blog/_slug.vue
@@ -44,7 +44,6 @@ export default {
     return {
       title: `${this.doc.title} | Pablo Sirera 👨🏼‍💻`,
       meta: [
-        // TODO: improve descriptions
         {
           hid: 'description',
           name: 'description',