-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump bundle to support Dropwizard 2.x.x #51
Conversation
pom.xml
Outdated
@@ -11,7 +11,7 @@ | |||
<groupId>org.pac4j</groupId> | |||
<artifactId>dropwizard-pac4j</artifactId> | |||
<packaging>jar</packaging> | |||
<version>3.0.1-SNAPSHOT</version> | |||
<version>4.0.0-SNAPSHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
went ahead and bumped a major for this
looks like a bunch of extraneous warn logging is coming in related to after bumping the versions, i can either drop warn logs in the build but a fix will probably need to be put in upstream it looks like |
Looks like pac4j/jax-rs-pac4j#45 was released. Can we move forward with this one now? |
@leleuj anything I can do to help with this one? |
Sure. I plan to upgrade the next major versions of So we could create a version 4.0.0 of |
I just upgraded |
@richeyh Can you update this PR with version 5.0.0-SNAPSHOT for |
@leleuj pr has been update |
not sure whats going on with the build i didn't touch this so not sure whats wrong with travis trying to download this |
OK. Thanks for the update. I restarted the build, Travis does not work very well lately. Is JDK 11 mandatory for Dropwizard v2? I created a 4.0.x branch and updated the master to v5.0.0-SNAPSHOT. This PR should go on a new major version. Another PR must be opened for the demo as well: https://github.com/pac4j/dropwizard-pac4j-demo |
yes jdk11 is mandatory, ill try to get some time to rebase this then for the new master branch and get a PR open for that demo application |
PR is open for the demo dependent on this being completed |
@@ -188,24 +315,17 @@ | |||
<version>3.2.0</version> | |||
</plugin> | |||
<plugin> | |||
<groupId>org.codehaus.mojo</groupId> | |||
<artifactId>findbugs-maven-plugin</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
find bugs is no longer supported and moved to spot bugs for java 11 support
Thanks for your contribution. Merging |
as 2.x.x has now been released anyone utilizing this bundle is going to need this bump in order to get there application working