Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump bundle to support Dropwizard 2.x.x #51

Merged
merged 9 commits into from
Dec 17, 2020
Merged

Conversation

richeyh
Copy link
Contributor

@richeyh richeyh commented Mar 26, 2020

as 2.x.x has now been released anyone utilizing this bundle is going to need this bump in order to get there application working

pom.xml Outdated
@@ -11,7 +11,7 @@
<groupId>org.pac4j</groupId>
<artifactId>dropwizard-pac4j</artifactId>
<packaging>jar</packaging>
<version>3.0.1-SNAPSHOT</version>
<version>4.0.0-SNAPSHOT</version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

went ahead and bumped a major for this

@richeyh
Copy link
Contributor Author

richeyh commented Mar 26, 2020

looks like a bunch of extraneous warn logging is coming in related to
MultiException stack 1 of 3
org.glassfish.hk2.api.UnsatisfiedDependencyException: There was no object available for injection at SystemInjecteeImpl(requiredType=Pac4JValueFactoryProvider$Pac4JProfileValueFactoryProvider,parent=Pac4JValueFactoryProvider$ProfileInjectionResolver,qualifiers={},position=0,optional=false,self=false,unqualified=null,2086477093)
at org.jvnet.hk2.internal.ThreeThirtyResolver.resolve(ThreeThirtyResolver.java:51)
at org.jvnet.hk2.internal.ClazzCreator.resolve(ClazzCreator.java:188)
at org.jvnet.hk2.internal.ClazzCreator.resolveAllDependencies(ClazzCreator.java:205)

after bumping the versions, i can either drop warn logs in the build but a fix will probably need to be put in upstream it looks like

@naveg
Copy link

naveg commented May 22, 2020

Looks like pac4j/jax-rs-pac4j#45 was released. Can we move forward with this one now?

@naveg
Copy link

naveg commented Jun 21, 2020

@leleuj anything I can do to help with this one?

@leleuj
Copy link
Member

leleuj commented Jun 22, 2020

Sure.

I plan to upgrade the next major versions of jax-rs-pac4j and dropwizard-pac4j to pac4j v4, but it won't be until September/October.

So we could create a version 4.0.0 of dropwizard-pac4j based on jax-rs-pac4j v3.0.3 and Dropwizard v2.
If you can submit a PR to do that (after the appropriate testing), I'll release the v4.0.0 of dropwizard-pac4j based on Dropwizard v2.

@leleuj
Copy link
Member

leleuj commented Sep 10, 2020

I just upgraded dropwizard-pac4j v4.0.0-SNAPSHOT to pac4j v4, based on jersey225-pac4j v4.0.0-SNAPSHOT.
I'll first cut the v4.0.0 releases then we'll upgrade to Dropwizard v2.

@leleuj
Copy link
Member

leleuj commented Sep 11, 2020

@richeyh Can you update this PR with version 5.0.0-SNAPSHOT for dropwizard-pac4j and Dropwizard v2?
Can you open another PR for the demo: https://github.com/pac4j/dropwizard-pac4j-demo? Thanks

@richeyh
Copy link
Contributor Author

richeyh commented Dec 15, 2020

@leleuj pr has been update

@richeyh
Copy link
Contributor Author

richeyh commented Dec 15, 2020

not sure whats going on with the build
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-resources-plugin:2.6:resources (default-resources) on project dropwizard-pac4j: Execution default-resources of goal org.apache.maven.plugins:maven-resources-plugin:2.6:resources failed: Plugin org.apache.maven.plugins:maven-resources-plugin:2.6 or one of its dependencies could not be resolved: Failed to collect dependencies at org.apache.maven.plugins:maven-resources-plugin:jar:2.6 -> org.apache.maven:maven-plugin-api:jar:2.0.6: Failed to read artifact descriptor for org.apache.maven:maven-plugin-api:jar:2.0.6: Could not transfer artifact org.apache.maven:maven-plugin-api:pom:2.0.6 from/to central (https://repo.maven.apache.org/maven2): Connection reset -> [Help 1]

i didn't touch this so not sure whats wrong with travis trying to download this

@leleuj
Copy link
Member

leleuj commented Dec 16, 2020

OK. Thanks for the update.

I restarted the build, Travis does not work very well lately.

Is JDK 11 mandatory for Dropwizard v2?

I created a 4.0.x branch and updated the master to v5.0.0-SNAPSHOT. This PR should go on a new major version.

Another PR must be opened for the demo as well: https://github.com/pac4j/dropwizard-pac4j-demo

@richeyh
Copy link
Contributor Author

richeyh commented Dec 16, 2020

yes jdk11 is mandatory, ill try to get some time to rebase this then for the new master branch and get a PR open for that demo application

@richeyh
Copy link
Contributor Author

richeyh commented Dec 16, 2020

PR is open for the demo dependent on this being completed

pom.xml Outdated Show resolved Hide resolved
@@ -188,24 +315,17 @@
<version>3.2.0</version>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>findbugs-maven-plugin</artifactId>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find bugs is no longer supported and moved to spot bugs for java 11 support

@richeyh richeyh requested a review from leleuj December 16, 2020 21:55
@leleuj
Copy link
Member

leleuj commented Dec 17, 2020

Thanks for your contribution. Merging

@leleuj leleuj merged commit 7bd5f58 into pac4j:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants