Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
testToJSONString
is detected flaky because theJsonHelper.toJSONString()
gives a non-deterministic output as JSONObject values are unordered.Solution
After modifying
testToJSONString
to expect 2 different string values, the test passes.Reason:
The JSON object is unordered and generally uses Maps as their internal data structure. And, according to HashMap documentation,
"This class makes no guarantees as to the order of the map; in particular, it does not guarantee that the order will remain constant over time."
This causes the
JsonHelper.toJSONString()
to give a non-deterministic output.Reproduction of the error
The test fails on 5/10 runs of the NonDex tool
Command to reproduce the failure:
mvn -pl pac4j-oauth edu.illinois:nondex-maven-plugin:2.1.7-SNAPSHOT:nondex -Dtest=org.pac4j.oauth.profile.JsonHelperTests#testToJSONString -DnondexRuns=10
Error Message: