Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paper citation to docs #259

Merged
merged 3 commits into from
Jan 10, 2023
Merged

Add paper citation to docs #259

merged 3 commits into from
Jan 10, 2023

Conversation

rebeccafair
Copy link
Member

@rebeccafair rebeccafair commented Jan 3, 2023

I wasn't sure what citation style to use for this, so I've just made sure all the information is there.

Alternatively, rather than adding to the citation docs page, we could update the CITATION.cff file so instead of having an overall DOI, we have multiple identifiers, one for the software itself, and one for the paper, as done here: https://github.com/citation-file-format/citation-file-format/blob/main/README.md#structure. Although that might need a bit more work as that would mean the citation file has a different format and https://github.com/pace-neutrons/Euphonic/tree/gh-pages may need updating.

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023

Codecov Report

Merging #259 (7642c6c) into master (47f6a8f) will not change coverage.
The diff coverage is n/a.

❗ Current head 7642c6c differs from pull request most recent head ce798b7. Consider uploading reports for the commit ce798b7 to get more accurate results

@@           Coverage Diff           @@
##           master     #259   +/-   ##
=======================================
  Coverage   96.98%   96.98%           
=======================================
  Files          26       26           
  Lines        3551     3551           
  Branches      632      632           
=======================================
  Hits         3444     3444           
  Misses         64       64           
  Partials       43       43           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

Test Results

     16 files   -        11       16 suites   - 11   33m 14s ⏱️ - 32m 47s
   983 tests  -          7     978 ✔️ +       29    5 💤 ±  0  0  -   29 
6 839 runs   - 18 570  6 801 ✔️  - 17 717  38 💤  - 92  0  - 754 

Results for commit ce798b7. ± Comparison against base commit 47f6a8f.

♻️ This comment has been updated with latest results.

@ajjackson
Copy link
Collaborator

Maybe the best place to put it in the CITATION.cff is as preferred-citation
https://github.com/citation-file-format/citation-file-format/blob/main/schema-guide.md#credit-redirection

I don't think it hurts to include it in the docs as well; then we have one human-friendly request and one machine-friendly!

@rebeccafair
Copy link
Member Author

Ah good point, I didn't know about preferred-citation. I have now added it.

The paper won't show up on the DOI landing page (https://doi.org/10.5286/SOFTWARE/EUPHONIC) unless I make some changes, but I think that's fine as its just the landing page for the software?

@ajjackson
Copy link
Collaborator

That's ok with me

@rebeccafair rebeccafair merged commit cbf55bd into master Jan 10, 2023
@rebeccafair rebeccafair deleted the add_citation branch January 10, 2023 08:29
rebeccafair added a commit that referenced this pull request Jan 12, 2023
commit 282cfa2
Author: Rebecca Fair <rebecca.fair@stfc.ac.uk>
Date:   Thu Jan 12 11:54:50 2023 +0000

    258 conda min (#260)

    * Test Conda on lest-than-latest Numpy version

    * Just test one environment

    * Fix workflow syntax

    * Don't run regular tests

    * Install Numpy 1.20

    * Install Numpy in commands_pre

    * Install Numpy 1.20

    * Change env name

    * Ensure build is ok with Numpy 1.21

    * Revert to Numpy 1.20

    * Revert workflow files

commit cbf55bd
Author: Rebecca Fair <rebecca.fair@stfc.ac.uk>
Date:   Tue Jan 10 08:29:36 2023 +0000

    Add paper citation to docs (#259)

    * Add citation to docs

    * Add preferred-citation to CITATION.cff

    * Update cite.rst

commit 47f6a8f
Author: Rebecca Fair <rebecca.fair@stfc.ac.uk>
Date:   Thu Dec 1 13:28:16 2022 +0000

    Update add-and-commit version

    Due to NodeJS 12 deprecation

commit 44abb7c
Author: Rebecca Fair <rebecca.fair@stfc.ac.uk>
Date:   Tue Nov 22 11:03:27 2022 +0000

    Update actions versions (Node.js 12 deprecation) (#252)

    * Update actions versions (Node.js 12 deprecation)

    Currently am getting the following warning on Github Actions runners:

    Node.js 12 actions are deprecated. For more information see:
    https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
    Please update the following actions to use Node.js 16:
    conda-incubator/setup-miniconda, actions/upload-artifact,
    codecov/codecov-action, conda-incubator/setup-miniconda

    * Update publish unit test results

    * Update deprecated 'files' in publish-unit-test-result-action

commit b6c94ca
Author: Rebecca Fair <rebecca.fair@stfc.ac.uk>
Date:   Thu Nov 10 11:26:23 2022 +0000

    Updates for v1.1.0 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants