Log first ip from X-Forwarded-For if present

pace · Aug 28, 2020 · 90c24b9 · 90c24b9
1 parent 94a2468
commit 90c24b9
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/maintenance/log/handler.go b/maintenance/log/handler.go
@@ -66,8 +66,8 @@ func ProxyAwareRemote(r *http.Request) string {
 	// ip from the usual headers
 	for _, h := range []string{"X-Forwarded-For", "X-Real-Ip"} {
 		addresses := strings.Split(r.Header.Get(h), ",")
-		for i := len(addresses) - 1; i >= 0; i-- {
-			ip := strings.TrimSpace(addresses[i])
+		for _, address := range addresses {
+			ip := strings.TrimSpace(address)
 			realIP := net.ParseIP(ip)
 			if !realIP.IsGlobalUnicast() {
 				continue // bad address, go to next