Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't log the health requests (#131) #134

Merged
merged 11 commits into from
Jan 28, 2020
Merged

don't log the health requests (#131) #134

merged 11 commits into from
Jan 28, 2020

Conversation

SchlottiP
Copy link
Contributor

added middleware that applies another middleware only if the request path not matches with any prefix of a list of ignored prefixes. Used the new Middleware for the logging and tracing of requests

…middleware only if the request path not matches with a any prefix of a list of ignored prefixes
@SchlottiP SchlottiP changed the title #131: don't log the health requests don't log the health requests (#131) Dec 17, 2019
maintenance/log/handler.go Outdated Show resolved Hide resolved
maintenance/tracing/tracing_test.go Outdated Show resolved Hide resolved
maintenance/util/ignore_prefix_middleware.go Outdated Show resolved Hide resolved
maintenance/tracing/tracing.go Show resolved Hide resolved
…thChecks

� Conflicts:
�	maintenance/log/handler.go
�	maintenance/tracing/tracing.go
maintenance/util/ignore_prefix_middleware.go Outdated Show resolved Hide resolved
http/router.go Outdated Show resolved Hide resolved
maintenance/util/ignore_prefix_middleware.go Outdated Show resolved Hide resolved
maintenance/util/ignore_prefix_middleware.go Outdated Show resolved Hide resolved
SchlottiP and others added 4 commits January 14, 2020 09:34
Co-Authored-By: Marius Neugebauer <marius.neugebauer@pacetelematics.com>
…thChecks

� Conflicts:
�	http/router_test.go
maintenance/util/ignore_prefix_handler.go Show resolved Hide resolved
maintenance/util/ignore_prefix_handler.go Outdated Show resolved Hide resolved
maintenance/util/ignore_prefix_handler.go Outdated Show resolved Hide resolved
maintenance/tracing/tracing.go Outdated Show resolved Hide resolved
@SchlottiP SchlottiP force-pushed the logsHealthChecks branch 2 times, most recently from f88dd21 to 01a7939 Compare January 23, 2020 13:06
Copy link
Contributor

@Teelevision Teelevision left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one little thing left. Then it's good to go.

http/router.go Outdated Show resolved Hide resolved
@Teelevision Teelevision merged commit 498699e into master Jan 28, 2020
@Teelevision Teelevision deleted the logsHealthChecks branch January 28, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants