Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling for multiple watchers. #6

Merged
merged 1 commit into from
Dec 19, 2021
Merged

Conversation

s-KaiNet
Copy link
Contributor

@s-KaiNet s-KaiNet commented Dec 12, 2021

This PR adds a few improvements:

  • on every page refresh a new connection is sent, as a result, it creates multiple unnecessary file watchers, which is a waste of resources. Now on socket close event it destroys the corresponding watcher
  • added a file path to the output to see the actual file that triggered the reload.

@pacexy
Copy link
Owner

pacexy commented Dec 19, 2021

LGTM

@pacexy pacexy merged commit 345cfec into pacexy:main Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants