Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move aws.s3 to Suggests due to it being orphaned #189

Merged
merged 1 commit into from Jan 15, 2020

Conversation

amoeba
Copy link
Contributor

@amoeba amoeba commented Jan 15, 2020

As discussed in #188,

  • Moves aws.s3 to Suggests due to it being orphaned.
  • Puts check_for_a_pkg checks for aws.s3 in spaces() and space_create() as those are our two exported functions.
  • Added a blurb in ?spaces_info about having to install aws.s3 first.

Closes #188

As discussed in pachadotdev#188,

- Moves aws.s3 to Suggests due to it being orphaned.
- Puts `check_for_a_pkg` checks for aws.s3 in spaces() and space_create() as those are our two exported functions.
- Added a blurb in ?spaces_info about having to install aws.s3 first.

Closes pachadotdev#188
@sckott sckott added this to the v0.8 milestone Jan 15, 2020
@sckott
Copy link
Collaborator

sckott commented Jan 15, 2020

LGTM

@sckott sckott merged commit 1a203b6 into pachadotdev:master Jan 15, 2020
@sckott sckott mentioned this pull request Jan 27, 2020
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws.s3 orphaned
2 participants