Split Modules

[curran]

Part of #15, the goal here is to split up large JS files ( > 500 lines) into smaller modules.

• viz/helpers/ui/legend.js Split Legend Module #31
• viz/types/helpers/graph/includes/svg.js
• viz/helpers/shapes/draw.js
• viz/helpers/shapes/edges.js
• viz/helpers/ui/timeline.js
• tooltip/create.js
• geom/largestrectangle.js
• viz/types/helpers/graph/includes/plot.js
• viz/types/rings.js

[curran]

@pachamaltese Regarding splitting modules, I'm thinking to tackle the largest files only and leave the rest. There are 9 files that are over 500 lines of code. I think limiting the scope of this task to just these files is a good idea. Thoughts?

  1     751 ./src/viz/helpers/ui/legend.js
  2     748 ./src/viz/types/helpers/graph/includes/svg.js
  3     738 ./src/viz/helpers/shapes/draw.js
  4     688 ./src/viz/helpers/shapes/edges.js
  5     664 ./src/viz/helpers/ui/timeline.js
  6     601 ./src/tooltip/create.js
  7     558 ./src/geom/largestrectangle.js
  8     556 ./src/viz/types/helpers/graph/includes/plot.js
  9     501 ./src/viz/types/rings.js

FWIW the command to get this list is find . -type f -exec wc -l {} + | sort -rn | head

[pachadotdev]

@curran I agree. I'll post an idea in regards to find

[curran]

@pachamaltese I'm noticing that there are no examples that use the legend component, so if I refactor that file there is no way to verify whether it breaks something or not. How would you like me to proceed?

[pachadotdev]

Hmmm. Can legend be removed without breaking something? I have examples for footers and headers.

…

On Wed, Jan 22, 2020, 9:03 AM Curran Kelleher ***@***.***> wrote: @pachamaltese <https://github.com/pachamaltese> I'm noticing that there are no examples that use the legend component, so if I refactor that file there is no way to verify whether it breaks something or not. How would you like me to proceed? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#26>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACM7UOL7LYX7ZVBKQROHMFLQ7AYX5ANCNFSM4KF3GSKQ> .

[pachadotdev]

Or give me a time to look into an old external hdd On Wed, Jan 22, 2020, 9:08 AM Mauricio Vargas <mauriciovargas@ug.uchile.cl> wrote:

…

Hmmm. Can legend be removed without breaking something? I have examples for footers and headers. On Wed, Jan 22, 2020, 9:03 AM Curran Kelleher ***@***.***> wrote: > @pachamaltese <https://github.com/pachamaltese> I'm noticing that there > are no examples that use the legend component, so if I refactor that file > there is no way to verify whether it breaks something or not. How would you > like me to proceed? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#26>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ACM7UOL7LYX7ZVBKQROHMFLQ7AYX5ANCNFSM4KF3GSKQ> > . >

[curran]

I can remove the legend module completely without breaking any of the examples that are there with HTML.

I wonder, do you have any R-based examples that use the legend that could be easily ported to JavaScript?

I'm happy to just remove the legend component if you don't want the library to be able to make legends.

[pachadotdev]

thanks Curran, right now I don't see a clear example where to use legends right now this has title, subtitle and footer [image: image.png] ————— *Mauricio Vargas Sepúlveda 帕夏* Do you like Data Science? visit pacha.hk 你爱科学数据专吗？你走pacha.hk

…

On Wed, Jan 22, 2020 at 10:32 AM Curran Kelleher ***@***.***> wrote: I can remove the legend module completely without breaking any of the examples that are there with HTML. [image: image] <https://user-images.githubusercontent.com/68416/72898182-9a5e4e00-3d49-11ea-9d1d-4aed9a4520d9.png> I wonder, do you have any R-based examples that use the legend that could be easily ported to JavaScript? I'm happy to just remove the legend component if you don't want the library to be able to make legends. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#26>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACM7UOKXUJT4HOHSGVIQ4LDQ7BDGTANCNFSM4KF3GSKQ> .

[pachadotdev]

I think legends are important... let me think a bit ————— *Mauricio Vargas Sepúlveda 帕夏* Do you like Data Science? visit pacha.hk 你爱科学数据专吗？你走pacha.hk On Wed, Jan 22, 2020 at 10:35 AM Mauricio Vargas < mauriciovargas@ug.uchile.cl> wrote:

…

thanks Curran, right now I don't see a clear example where to use legends right now this has title, subtitle and footer [image: image.png] ————— *Mauricio Vargas Sepúlveda 帕夏* Do you like Data Science? visit pacha.hk 你爱科学数据专吗？你走pacha.hk On Wed, Jan 22, 2020 at 10:32 AM Curran Kelleher ***@***.***> wrote: > I can remove the legend module completely without breaking any of the > examples that are there with HTML. > > [image: image] > <https://user-images.githubusercontent.com/68416/72898182-9a5e4e00-3d49-11ea-9d1d-4aed9a4520d9.png> > > I wonder, do you have any R-based examples that use the legend that could > be easily ported to JavaScript? > > I'm happy to just remove the legend component if you don't want the > library to be able to make legends. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#26>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ACM7UOKXUJT4HOHSGVIQ4LDQ7BDGTANCNFSM4KF3GSKQ> > . >

[pachadotdev]

@curran I added a very stupid example here https://github.com/pachamaltese/d3po/blob/master/dev/treemap_with_legend.html

I shall port legends after remembering that 3 yrs ago I used those a lot

[curran]

Excellent! Thank you for adding that.

[curran]

Legend refactoring ready for review #31