Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #137

Merged
merged 32 commits into from
Mar 12, 2024
Merged

Develop #137

merged 32 commits into from
Mar 12, 2024

Conversation

pachi81
Copy link
Owner

@pachi81 pachi81 commented Feb 22, 2024

No description provided.

@pachi81
Copy link
Owner Author

pachi81 commented Feb 28, 2024

@froster82
Copy link
Collaborator

@pachi81 PL version of 299-300 done.
IoB in Juggluco ver. 7.5.0 still not available ;/

@pachi81
Copy link
Owner Author

pachi81 commented Feb 29, 2024

@pachi81 IoB in Juggluco ver. 7.5.0 still not available ;/

Yes, he hasn´t replied to my issue... It seem, he do not want to add it :-/

@pachi81
Copy link
Owner Author

pachi81 commented Mar 5, 2024

@froster82 I have changed some more string for GlucoDataAuto.
Can you translate them? Thank you!

I also have tried the last version of Juggluco and it is gone. jka also does not answer to my feature request, so it seems, he does not want it...

@froster82
Copy link
Collaborator

@pachi81, I will take a look at them tomorrow.
As for JKA, try and write to him in an email. I always get an answer when I write that way.

@pachi81
Copy link
Owner Author

pachi81 commented Mar 10, 2024

@froster82 Hi, I need some more translation, as google forced me, to remove the automatically set a permission. Now, I have to ask the user...

@froster82
Copy link
Collaborator

@pachi81, hi! I will read about the wording of those permissions in Polish and will translate it. Do you have the German version for 'schedule exact alarm'? Sometimes it's easier to find the right Polish equivalent using also German.

@pachi81
Copy link
Owner Author

pachi81 commented Mar 10, 2024

This is the setting I mean. In code it is called SCHEDULE EXACT ALARM...
Screenshot_20240310_214202_Settings

It is used to trigger the app after an interval for example for the obsolete values or to request data from nightscout or librelink.

@pachi81
Copy link
Owner Author

pachi81 commented Mar 11, 2024

@froster82 I have updated the strings again and removed the part with google, as it is not relevant...
Here is the german to polish translation:

W przypadku wszystkich zadań związanych z czasem i interwałami aplikacja wymaga autoryzacji alarmów i przypomnień.
Aplikacja nie zmienia żadnych alarmów ani przypomnień skonfigurowanych przez użytkownika. Wymaga jedynie autoryzacji dla wewnętrznych wyzwalaczy.
Po naciśnięciu przycisku OK aplikacja przekieruje użytkownika do odpowiednich ustawień autoryzacji. Należy aktywować tę autoryzację dla GlucoDataHandler.

@froster82
Copy link
Collaborator

@pachi81 I didn't mean translation already into Polish ;) I can deale with that ;) Sometimes, however, when I am not familiar with the exact vocabulary concerning a specific field, it is easier to have two language versions. German is a bit more similar to Polish in some cases, because we have a lot more borrowings form German than form English.

@pachi81
Copy link
Owner Author

pachi81 commented Mar 11, 2024

@froster82 OK, I get it :-)
Yes, in English there are less words, so I know, what you are meaning. You can always check the German translation in the related string files:
https://github.com/pachi81/GlucoDataHandler/pull/137/files#diff-1369f26acce2dcc2d7d2807f3ebe092dd654da291430c78db8f1fe1491df65d5

Add the moment I´m really annoyed by Google policies... Which each release they are finding a new reason for reject my app. This setting for example, I´m using since the beginning of my app and now, they complain about :-(

@froster82
Copy link
Collaborator

@pachi81, Polish version done. That above screen really helped me a lot, because in my Android 10 I think I do not have this permission required. I hope Google doesn't mess around with you too much and you will be able to deal with all their complaining.

@pachi81
Copy link
Owner Author

pachi81 commented Mar 11, 2024

@pachi81, Polish version done. That above screen really helped me a lot, because in my Android 10 I think I do not have this permission required. I hope Google doesn't mess around with you too much and you will be able to deal with all their complaining.

@froster82 Thank you! Yes, this permission is only for Android 12 and above. Good to know, that you are using Android 10. So you can check, if all works like expected with the next version.

@pachi81
Copy link
Owner Author

pachi81 commented Mar 11, 2024

@froster82 New version is online. Should be no problem for Android 10.

Here are 2 screenshots for your translation:
Screenshot_20240311_185835_GlucoDataHandler
Screenshot_20240311_185850_GlucoDataHandler

@froster82
Copy link
Collaborator

@pachi81 on A10 everything looks fine. No errors or crashes.

froster82 and others added 2 commits March 12, 2024 08:10
I modified the Polish version a bit to make it more user-friendly. The first attempt is sometimes rough. I think, now it looks better.
@pachi81 pachi81 merged commit 6382dcc into master Mar 12, 2024
@pachi81 pachi81 deleted the develop branch March 12, 2024 17:27
@froster82
Copy link
Collaborator

@pachi81, hi! I am writing with an idea for future development.
One parent on the Polish FB group suggested that it would be useful to have a log of say 5 recent delta changes. This would show the rate of glucose change. Of course, if possible, you could log and show on a widget the glucose level, delta from the previous value, and maybe time.
This is just an idea to consider. What do you think?
Have a nice day!

@pachi81
Copy link
Owner Author

pachi81 commented Mar 15, 2024

@froster82 I don´t think, this make sense. This sounds more like a graph, where you can see it. And graph support will come later.
I think a better way is doing it like in AAPS to have a delta/minute, delta/5 minutes and delta/15 minutes.
But also for these values I need historical values, which will come with the graph...

@froster82
Copy link
Collaborator

OK, this was just an idea based on the lack of graph - so far. But if you plan to introduce it in the future, then you are right - it loses its validity :)

@pachi81 pachi81 linked an issue Jun 5, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broadcast to WatchDrip+
2 participants