feat: Show information about notification fetches on "About" screen #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some users report that Pachli is not retrieving/displaying notifications in a timely fashion. To assist in diagnosing these errors, provide an additional set of tabs on the "About" screen that contain information about how Pachli is fetching notifications, and if not, why not. Allow the user to save notification related logs and other details to a file that can be attached to an e-mail or bug report. Recording data: - Provide a `NotificationConfig` singleton with properties to record different aspects of the notification configuration. Update these properties as different notification actions occur. - Store logs in a `LogEntryEntity` table. Log events of interest with a new `Timber` `LogEntryTree` that is planted in all cases. - Add `PruneLogEntryEntityWorker` to trim saved logs to the last 48 hours. Display: - Add a `NotificationFragment` to `AboutActivity`. It hosts two other fragments in tabs to show details from `NotificationConfig` and the relevant logs, as well as controls for interacting with them. Bug fixes: - Filter out notifications with a null tag when processing active notifications, prevents an NPE crash Other changes: - Log more details when errors occur so the bug reports are more helpful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users report that Pachli is not retrieving/displaying notifications in a timely fashion.
To assist in diagnosing these errors, provide an additional set of tabs on the "About" screen that contain information about how Pachli is fetching notifications, and if not, why not.
Allow the user to save notification related logs and other details to a file that can be attached to an e-mail or bug report.
Recording data:
Provide a
NotificationConfigsingleton with properties to record different aspects of the notification configuration. Update these properties as different notification actions occur.Store logs in a
LogEntryEntitytable. Log events of interest with a newTimberLogEntryTreethat is planted in all cases.Add
PruneLogEntryEntityWorkerto trim saved logs to the last 48 hours.Display:
NotificationFragmenttoAboutActivity. It hosts two other fragments in tabs to show details fromNotificationConfigand the relevant logs, as well as controls for interacting with them.Bug fixes:
Other changes: