fix: Improve accessibility of ComposeActivity bottomsheets and buttons #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous bottomsheets did set a minimum height for the menu items, so they were less than the recommended 48dp minimum. Fix that to improve the overall accessibility. Always highlight the "visibilty" icon, to make it clear that it's something that is set (even if to the default). Show the visibility icon on the "Toot" button as an additional reminder to the user. Other changes: - Use the "filled" style for all icons (the visibility icons had the "outlined" style) - Use the `makeIcon` helper function. - Use the `Status.Visibility` extension functions to determine the icon for each visibility type, reducing code duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous bottomsheets did set a minimum height for the menu items, so they were less than the recommended 48dp minimum. Fix that to improve the overall accessibility.
Always highlight the "visibilty" icon, to make it clear that it's something that is set (even if to the default).
Show the visibility icon on the "Toot" button as an additional reminder to the user.
Other changes:
Use the "filled" style for all icons (the visibility icons had the "outlined" style)
Use the
makeIconhelper function.Use the
Status.Visibilityextension functions to determine the icon for each visibility type, reducing code duplication.