Fix dplyr grouping warning (#102) #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing column before ungrouping
|
man, you're not giving me any time to kill off these bugs ;) looks great. thanks again! |
|
You're welcome! I figured if I could help with pushing your project the next release, then I should just jump in and do so. :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @pimentel,
I noticed the warning described in #102 too. I discovered it was caused by removing the grouping column
x_groupbefore ungrouping insliding_window_grouping, so dplyr gives a warning because it expects the groups to always be present. I found this out from this stackoverflow threadThis should fix the problem.