Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tests for ".N" target mappings #115

Merged
merged 5 commits into from
Jun 2, 2017
Merged

Conversation

warrenmcg
Copy link
Collaborator

Hi @pimentel,

I've put together some quick tests to make sure that sleuth_prep only provides a warning if ".N" target_ids are provided with the Kallisto results, but not with the target mappings.

Note that this depends on incorporating the code from my previous pull request, since it runs the one sample from small_test_data, and otherwise the code will throw an error when run.

Note also that there is an error if the opposite occurs (Kallisto results do not have ".N", but the target mappings do), but I presume this case isn't accounted for because it's an unusual edge case?

@pimentel pimentel merged commit 41d0c87 into pachterlab:devel Jun 2, 2017
@pimentel
Copy link
Collaborator

pimentel commented Jun 2, 2017

as usual, thanks a bunch!

indeed, I would rather the user remove the ".N" from the target_id in the target_mapping manually so that they are aware of the issue. and also this is not typical. when the issue is in the kallisto annotation then it is harder to deal with and quite difficult within the sleuth framework which is why we test for it.

@warrenmcg warrenmcg deleted the n_tests branch June 3, 2017 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants