Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address #113 - patch bug where TPM bootstrap summary target_ids are moved #116

Merged
merged 1 commit into from Jun 2, 2017

Conversation

warrenmcg
Copy link
Collaborator

Hi @pimentel,

To address #113, I realized that the error occurs because the TPM bootstrap summary object in bs_quants has no rownames, so no target_ids will be found. I further discovered that target_ids are removed from the tpm bootstrap summary object after the counts_to_tpm step in process_bootstrap. I've made a patch that makes sure that the target_ids remain. This should fix the issue.

@pimentel pimentel merged commit cbbd938 into pachterlab:devel Jun 2, 2017
@pimentel
Copy link
Collaborator

pimentel commented Jun 2, 2017

thank you!

@warrenmcg warrenmcg deleted the issue113 branch June 3, 2017 03:33
@Cyrus714
Copy link

Cyrus714 commented Mar 4, 2020

Hi, I had the same problem with some transcripts, not all of them, but I still didn't figure out how to fix that. For some transcripts, I get charts for est_counts, but for some others, that I know they should be in my analysis, I get the message "Error: couldn't find target_id".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants