address #113 - patch bug where TPM bootstrap summary target_ids are moved #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @pimentel,
To address #113, I realized that the error occurs because the TPM bootstrap summary object in
bs_quants
has no rownames, so no target_ids will be found. I further discovered that target_ids are removed from the tpm bootstrap summary object after thecounts_to_tpm
step inprocess_bootstrap
. I've made a patch that makes sure that the target_ids remain. This should fix the issue.