Shiny and Plot Fixes / Enhancements #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments + see pull request pachterlab#143 for details on the specific changes
warrenmcg
changed the title
…combo of tests
+ this will fix all "group_by" or "gene_column" choice boxes
|
fantastic work, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @pimentel,
First a small thing:
For
plot_bootstrap, the call to facet.wrap keeps giving me a warning (at least in R 3.3) that theswitch =argument is deprecated infacet_wrap, and to usestrip.positioninstead.Next, found that my gene mode changes to Shiny, and the documentation disappeared (probably from the merge). I pulled those changes from my ALR branch, and brought them here.
For a detailed description of the changes, you can go back to pull request #143.
I'll update this if I find any more changes. I'll double check the bug you brought up in #158, and make the necessary changes here.