Drop unused factor levels when prepping the sleuth object. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes pachterlab#69. Thanks to @marypiper for opening the issue with a nice test dataset demonstrating the issue.
|
Hi, Wondering why not just |
|
@gresteban -- ah, I didn't know droplevels() worked like that. Thanks-- I swapped over to using that one liner instead. |
|
Thank you for doing this... I just spent nearly a full day trying to figure out why sleuth_fit was failing... it was due to empty factor levels. |
warrenmcg
added a commit
to warrenmcg/sleuth
that referenced
this pull request
Mar 13, 2017
|
this looks useful -- thanks! really sorry about the massive delay on this. will merge in by the end of this week. thanks, harold |
|
No worries, thanks Harold! |
|
Merging Warren's p/r will get this in and I think all the merge conflicts are good so I'll close this in favor of his request. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
This fixes #69, which was caused by unrepresented factor levels hanging around in the sample_to_covariates matrix.