Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gene annotations when using "sleuth_results", addressing #86 #95

Closed
wants to merge 1 commit into from

Conversation

warrenmcg
Copy link
Collaborator

Hi sleuth team,

I have added a small bit of code to address #86, where a user noticed that no annotations were included in the results table after using aggregation_column then sleuth_results.

The code first removes the target_id column (the "transcripts") from the target_mapping table, and then reduces it down to unique rows: one for each "gene" (aggregation_column).
The code then uses dplyr's left_join to put them together, using the syntax for by to join two different columns (target_id in the results table, and obj$gene_column for the reduced target_mapping table).

Because lintr is currently disabled and the "give a design matrix" test is broken on the master branch, I didn't bother making those changes again. I tried to make sure the added was lintr clean. I don't think additional tests are necessary for this additional code, because the necessary checks are done during sleuth_prep.

Let me know if you have any feedback!

@warrenmcg
Copy link
Collaborator Author

I've decided to close this pull request in favor of the new one. Let me know if you wish to focus on this one.

@warrenmcg warrenmcg closed this Apr 22, 2017
@pimentel pimentel mentioned this pull request May 29, 2017
@warrenmcg warrenmcg deleted the issue86 branch June 3, 2017 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant