Fix problem from tidyverse/ggplot2#5333, boundaries showing despite l…

…inewidth = 0 on Windows. Closing #13. Version bumped to make this change visible to Bioconductor users. I thought I was done with bugs for now when I version bumped earlier today, but I was wrong.
pachterlab · Sep 20, 2023 · 3bff99e · 3bff99e
1 parent 773d7a4
commit 3bff99e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: Voyager
 Type: Package
 Title: From geospatial to spatial omics
-Version: 1.2.6
+Version: 1.2.7
 Authors@R: 
     c(person("Lambda", "Moses", email = "dlu2@caltech.edu", 
     role = c("aut", "cre"),

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,6 @@
+# Version 1.2.7 (09/19/2023)
+* Polygon boundaries will show despite linewidth = 0 for Windows users. Set color = NA for polygons if linewidth = 0 so default will work for Windows.
+
 # Version 1.2.6 (09/19/2023)
 * Fixed bug in plotColGraph when one out of multiple samples is plotted.
 * Allow 16 bit images in spatial plotting functions.

diff --git a/R/plot.R b/R/plot.R
@@ -55,6 +55,7 @@ getDivergeRange <- function(values, diverge_center = 0) {
     } else {
         # i.e. polygons
         names_use <- c("linewidth", "linetype", "fill", "color", "alpha")
+        if (isTRUE(all.equal(0, fixed$linewidth))) fixed$color <- NA
     }
     fixed_applicable <- .drop_null_list(fixed[names_use])
     fixed_applicable