Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rslex] Improve how we pass uri into request_builder #44

Closed
albscui opened this issue Jul 20, 2021 · 1 comment
Closed

[rslex] Improve how we pass uri into request_builder #44

albscui opened this issue Jul 20, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@albscui
Copy link
Contributor

albscui commented Jul 20, 2021

In rslex-pachyderm/src/pachyderm_stream_handler/request_builder.rs

impl RequestBuilder {
    /// Build a RequestBuilder from uri and SyncRecord.
    /// Return InvalidInput if uri is ill-formated.
    pub fn new(uri: &str, credential: String) -> StreamResult<RequestBuilder> {
        // Sometimes we get instantiated with uri like
        // commit.branch.repo/foo, sometimes like
        // http://localhost:30600/commit.branch.repo/foo workaround the latter
        // case by special-casing it for now.
        let the_uri = uri.strip_prefix("http://localhost:30600/").unwrap_or(uri);
...
@albscui albscui added the enhancement New feature or request label Jul 20, 2021
@albscui
Copy link
Contributor Author

albscui commented Aug 17, 2021

Done

@albscui albscui closed this as completed Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant