-
Notifications
You must be signed in to change notification settings - Fork 566
/
pipeline_controller.go
791 lines (750 loc) · 29.1 KB
/
pipeline_controller.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
package server
import (
"context"
"fmt"
"strconv"
"strings"
"sync"
"time"
"github.com/pachyderm/pachyderm/v2/src/internal/backoff"
"github.com/pachyderm/pachyderm/v2/src/internal/client"
"github.com/pachyderm/pachyderm/v2/src/internal/errors"
"github.com/pachyderm/pachyderm/v2/src/internal/errutil"
"github.com/pachyderm/pachyderm/v2/src/internal/log"
"github.com/pachyderm/pachyderm/v2/src/internal/pctx"
"github.com/pachyderm/pachyderm/v2/src/internal/ppsutil"
"github.com/pachyderm/pachyderm/v2/src/internal/tracing"
"github.com/pachyderm/pachyderm/v2/src/internal/tracing/extended"
"github.com/pachyderm/pachyderm/v2/src/pfs"
"github.com/pachyderm/pachyderm/v2/src/pps"
"github.com/pachyderm/pachyderm/v2/src/server/worker/driver"
"github.com/pachyderm/pachyderm/v2/src/task"
"github.com/pachyderm/pachyderm/v2/src/version"
"go.uber.org/zap"
opentracing "github.com/opentracing/opentracing-go"
v1 "k8s.io/api/core/v1"
)
func max(is ...int) int {
if len(is) == 0 {
return 0
}
max := is[0]
for _, i := range is {
if i > max {
max = i
}
}
return max
}
type pcManager struct {
sync.Mutex
pcs map[pipelineKey]*pipelineController
}
func newPcManager() *pcManager {
return &pcManager{
pcs: make(map[pipelineKey]*pipelineController),
}
}
type sideEffectName int32
const (
sideEffectName_KUBERNETES_RESOURCES sideEffectName = 0
sideEffectName_FINISH_COMMITS sideEffectName = 1
sideEffectName_RESTART sideEffectName = 2
sideEffectName_SCALE_WORKERS sideEffectName = 3
sideEffectName_PIPELINE_MONITOR sideEffectName = 4
sideEffectName_CRASH_MONITOR sideEffectName = 5
)
// String implements fmt.Stringer.
func (s sideEffectName) String() string {
switch s {
case sideEffectName_KUBERNETES_RESOURCES:
return "KUBERNETES_RESOURCES"
case sideEffectName_FINISH_COMMITS:
return "FINISH_COMMITS"
case sideEffectName_RESTART:
return "RESTART"
case sideEffectName_SCALE_WORKERS:
return "SCALE_WORKERS"
case sideEffectName_PIPELINE_MONITOR:
return "PIPELINE_MONITOR"
case sideEffectName_CRASH_MONITOR:
return "CRASH_MONITOR"
default:
return "UNKNOWN"
}
}
type sideEffectToggle int32
const (
sideEffectToggle_NONE sideEffectToggle = 0
sideEffectToggle_UP sideEffectToggle = 1
sideEffectToggle_DOWN sideEffectToggle = 2
)
// String implements fmt.Stringer.
func (s sideEffectToggle) String() string {
switch s {
case sideEffectToggle_NONE:
return "NONE"
case sideEffectToggle_UP:
return "UP"
case sideEffectToggle_DOWN:
return "DOWN"
default:
return "UNKNOWN"
}
}
// sideEffect intends to capture a state changing operation that the pipeline controller may apply
// NOTE: the PipelineInfo & ReplicationController arguments supplied to apply should be treated as read only copies
type sideEffect struct {
apply func(context.Context, *pipelineController, *pps.PipelineInfo, *v1.ReplicationController) error
name sideEffectName
toggle sideEffectToggle
}
func (se sideEffect) equals(o sideEffect) bool {
return se.name == o.name && se.toggle == o.toggle
}
// String implements fmt.Stringer.
func (se sideEffect) String() string {
b := new(strings.Builder)
b.WriteString(se.name.String())
if t := se.toggle; t != sideEffectToggle_NONE {
b.WriteString(" (")
b.WriteString(t.String())
b.WriteString(")")
}
return b.String()
}
func ResourcesSideEffect(toggle sideEffectToggle) sideEffect {
return sideEffect{
name: sideEffectName_KUBERNETES_RESOURCES,
toggle: toggle,
apply: func(ctx context.Context, pc *pipelineController, pi *pps.PipelineInfo, _ *v1.ReplicationController) error {
if toggle == sideEffectToggle_UP {
return errors.EnsureStack(pc.iDriver.CreatePipelineResources(ctx, pi))
}
if err := pc.deletePipelineResources(); err != nil {
// retry, but the pipeline has already failed
return stepError{
error: errors.Wrap(err, "error deleting resources for failing pipeline"),
retry: true,
}
}
return nil
},
}
}
func FinishCommitsSideEffect() sideEffect {
return sideEffect{
name: sideEffectName_FINISH_COMMITS,
toggle: sideEffectToggle_NONE,
apply: func(ctx context.Context, pc *pipelineController, pi *pps.PipelineInfo, _ *v1.ReplicationController) error {
return pc.finishPipelineOutputCommits(ctx, pi)
},
}
}
func RestartSideEffect() sideEffect {
return sideEffect{
name: sideEffectName_RESTART,
toggle: sideEffectToggle_NONE,
apply: func(ctx context.Context, pc *pipelineController, pi *pps.PipelineInfo, rc *v1.ReplicationController) error {
return pc.restartPipeline(ctx, pi, rc)
},
}
}
func ScaleWorkersSideEffect(toggle sideEffectToggle) sideEffect {
return sideEffect{
name: sideEffectName_SCALE_WORKERS,
toggle: toggle,
apply: func(ctx context.Context, pc *pipelineController, pi *pps.PipelineInfo, rc *v1.ReplicationController) error {
if toggle == sideEffectToggle_UP {
return pc.scaleUpPipeline(ctx, pi, rc)
}
return pc.scaleDownPipeline(ctx, pi, rc)
},
}
}
func PipelineMonitorSideEffect(toggle sideEffectToggle) sideEffect {
return sideEffect{
name: sideEffectName_PIPELINE_MONITOR,
toggle: toggle,
apply: func(ctx context.Context, pc *pipelineController, pi *pps.PipelineInfo, rc *v1.ReplicationController) error {
if toggle == sideEffectToggle_UP {
pc.startPipelineMonitor(ctx, pi)
} else {
pc.stopPipelineMonitor()
}
return nil
},
}
}
func CrashingMonitorSideEffect(toggle sideEffectToggle) sideEffect {
return sideEffect{
name: sideEffectName_CRASH_MONITOR,
toggle: toggle,
apply: func(_ context.Context, pc *pipelineController, pi *pps.PipelineInfo, _ *v1.ReplicationController) error {
if toggle == sideEffectToggle_UP {
pc.startCrashingPipelineMonitor(pi)
} else {
pc.stopCrashingPipelineMonitor()
}
return nil
},
}
}
// pipelineController contains all of the relevent current state for a pipeline. It's
// used by step() to take any necessary actions
type pipelineController struct {
// a pachyderm client wrapping this operation's context (child of the PPS
// master's context, and cancelled at the end of Start())
ctx context.Context
cancel context.CancelFunc
pipeline *pps.Pipeline
env Env
etcdPrefix string
monitorCancel func()
crashingMonitorCancel func()
bumpChan chan time.Time
pcMgr *pcManager
psDriver PipelineStateDriver
iDriver InfraDriver
scaleUpInterval time.Duration
crashingBackoff time.Duration
}
var (
errRCNotFound = errors.New("RC not found")
errUnexpectedRC = errors.New("unexpected RC")
errTooManyRCs = errors.New("multiple RCs found for pipeline")
errStaleRC = errors.New("RC doesn't match pipeline version (likely stale)")
)
func (m *ppsMaster) newPipelineController(ctx context.Context, cancel context.CancelFunc, pipeline *pps.Pipeline) *pipelineController {
pc := &pipelineController{
ctx: pctx.Child(m.masterCtx, fmt.Sprintf("pipelineController(%s)", pipeline.String()), pctx.WithFields(zap.Stringer("pipeline", pipeline))),
cancel: cancel,
// pipeline name is recorded separately in the case we are running a delete operation and pipelineInfo isn't available in the DB
pipeline: pipeline,
env: m.env,
etcdPrefix: m.etcdPrefix,
iDriver: m.kd,
psDriver: m.sd,
bumpChan: make(chan time.Time, 1),
pcMgr: m.pcMgr,
scaleUpInterval: m.scaleUpInterval,
crashingBackoff: m.crashingBackoff,
}
return pc
}
// Bump signals the pipelineController goro to either process the latest state
// of the pipeline now, or once its done with its current processing iteration.
//
// This function is expected to be called while holding the pcMgr lock.
// This helps guard the critical section when the goroutine is cleaned up
// as part of a pipeline deletion event in pipelineController.tryFinish().
//
// Note: since pc.bumpChan is a buffered channel of length 1, Bump() will
// add to the channel if it's empty, and do nothing otherwise.
func (pc *pipelineController) Bump(ts time.Time) {
select {
case pc.bumpChan <- ts:
default:
}
}
// Start calls step for the given pipeline in a backoff loop.
// When it encounters a stepError, returned by most pipeline controller helper
// functions, it uses the fields to decide whether to retry the step or,
// if the retries have been exhausted, fail the pipeline.
//
// Other errors are simply logged and ignored, assuming that some future polling
// of the pipeline will succeed.
func (pc *pipelineController) Start(timestamp time.Time) {
pc.Bump(timestamp)
for {
select {
case <-pc.ctx.Done():
return
case ts := <-pc.bumpChan:
// pc.step returns true if the pipeline was deleted, and the controller can try to shutdown
if isDelete, err := pc.step(ts); err != nil {
log.Error(pc.ctx, "failed to run step", zap.Error(err))
} else if isDelete {
pc.tryFinish()
}
}
}
}
// finishes the pc if it isn't bumped
func (pc *pipelineController) tryFinish() {
pc.pcMgr.Lock()
defer pc.pcMgr.Unlock()
select {
case ts := <-pc.bumpChan:
pc.Bump(ts)
default:
pc.cancel()
delete(pc.pcMgr.pcs, toKey(pc.pipeline))
}
}
// step fetches 'pipelineInfo', the latest pipeline pointer in the pipeline collection, and
// 1. retrieves its full pipeline spec and RC into the 'Details' field
// 2. makes whatever changes are needed to bring the RC in line with the (new) spec
// 3. updates 'pipelineInfo', if needed, to reflect the action it just took
//
// returns true if the pipeline is deleted, and the pipelineController can try to shutdown
func (pc *pipelineController) step(timestamp time.Time) (isDelete bool, retErr error) {
log.Debug(pc.ctx, "processing event")
// Handle tracing
span, _ := extended.AddSpanToAnyPipelineTrace(pc.ctx, pc.env.EtcdClient, pc.pipeline, "/pps.Master/ProcessPipelineUpdate")
if !timestamp.IsZero() {
tracing.TagAnySpan(span, "update-time", timestamp)
} else {
tracing.TagAnySpan(span, "pollpipelines-or-autoscaling-event", "true")
}
defer tracing.FinishAnySpan(span, "err", retErr)
// derive the latest pipelineInfo with a corresponding auth'd context
pi, ctx, err := pc.psDriver.FetchState(pc.ctx, pc.pipeline)
if err != nil {
// if we fail to create a new step, there was an error querying the pipeline info, and there's nothing we can do
log.Error(pc.ctx, "failed to set up step data to handle event for pipeline", zap.Error(err))
return false, errors.Wrapf(err, "failing pipeline %q", pc.pipeline)
} else if pi == nil {
// interpret the event as a delete operation
if err := pc.deletePipelineResources(); err != nil {
log.Error(pc.ctx, "error deleting pipelineController resources for pipeline", zap.Error(err))
return true, errors.Wrapf(err, "error deleting pipelineController resources for pipeline '%s'", pc.pipeline)
}
return true, nil
}
var stepErr stepError
// TODO(msteffen) should this fail the pipeline? (currently getRC will restart
// the pipeline indefinitely)
rc, restart, err := pc.getRC(ctx, pi)
if restart {
if err := pc.restartPipeline(ctx, pi, rc); err != nil {
return false, err
}
return false, errors.EnsureStack(pc.psDriver.SetState(ctx, pi.SpecCommit, pps.PipelineState_PIPELINE_RESTARTING, "could not get RC."))
}
if err != nil && !errors.Is(err, errRCNotFound) {
return false, err
}
targetState, sideEffects, reason, err := evaluate(pi, rc)
if err != nil {
return false, err
}
errCount := 0
err = backoff.RetryNotify(func() error {
// Create/Modify/Delete pipeline resources as needed per new state
return pc.apply(ctx, pi, rc, targetState, sideEffects, reason)
}, backoff.NewExponentialBackOff(), func(err error, d time.Duration) error {
errCount++
if errors.As(err, &stepErr) {
if stepErr.retry && errCount < maxErrCount {
log.Error(pc.ctx, "error updating resources", zap.Error(err), zap.Duration("retryAfter", d))
return nil
}
}
return errors.Wrapf(err, "could not update resource for pipeline %q", pc.pipeline)
})
if errors.As(err, &stepErr) && stepErr.failPipeline {
failError := pc.psDriver.SetState(ctx,
pi.SpecCommit,
pps.PipelineState_PIPELINE_FAILURE,
fmt.Sprintf("could not update resources after %d attempts: %v", errCount, err),
)
if failError != nil {
log.Error(pc.ctx, "error failing pipeline after step error", zap.NamedError("stepError", stepErr), zap.NamedError("failError", failError))
return false, errors.Wrapf(failError, "error failing pipeline %q after step error (%v)", pc.pipeline, stepErr)
}
}
return false, err
}
func evaluate(pi *pps.PipelineInfo, rc *v1.ReplicationController) (pps.PipelineState, []sideEffect, string, error) {
if pi.State == pps.PipelineState_PIPELINE_FAILURE {
return pps.PipelineState_PIPELINE_FAILURE,
[]sideEffect{
FinishCommitsSideEffect(),
ResourcesSideEffect(sideEffectToggle_DOWN),
}, "", nil
}
if pi.State == pps.PipelineState_PIPELINE_STARTING || pi.State == pps.PipelineState_PIPELINE_RESTARTING {
sideEffects := make([]sideEffect, 0)
if rc == nil {
sideEffects = append(sideEffects, ResourcesSideEffect(sideEffectToggle_UP))
}
if pi.Stopped {
return pps.PipelineState_PIPELINE_PAUSED, sideEffects, "", nil
}
sideEffects = append(sideEffects, CrashingMonitorSideEffect(sideEffectToggle_DOWN))
if pi.Details.Autoscaling && pi.State == pps.PipelineState_PIPELINE_STARTING {
return pps.PipelineState_PIPELINE_STANDBY, sideEffects, "", nil
}
if pi.State == pps.PipelineState_PIPELINE_RESTARTING { // the conditional isn't necessary but provides clearer semantics
sideEffects = append(sideEffects, PipelineMonitorSideEffect(sideEffectToggle_DOWN))
}
return pps.PipelineState_PIPELINE_RUNNING, sideEffects, "", nil
}
if rc == nil {
// may happen if an external system deletes the RC
return pps.PipelineState_PIPELINE_RESTARTING, []sideEffect{RestartSideEffect()}, "missing RC", nil
}
if pi.State == pps.PipelineState_PIPELINE_PAUSED {
if !pi.Stopped {
// StartPipeline has been called (so spec commit is updated), but new spec
// commit hasn't been propagated to PipelineInfo or RC yet
if pi.Details.Autoscaling {
return pps.PipelineState_PIPELINE_STANDBY, nil, "", nil
}
return pps.PipelineState_PIPELINE_RUNNING, nil, "", nil
}
return pi.State, []sideEffect{
// don't want cron commits or STANDBY state changes while pipeline is
// stopped
PipelineMonitorSideEffect(sideEffectToggle_DOWN),
CrashingMonitorSideEffect(sideEffectToggle_DOWN),
// default: scale down if pause/standby hasn't propagated to collection yet
ScaleWorkersSideEffect(sideEffectToggle_DOWN),
}, "", nil
}
if pi.Stopped {
return pps.PipelineState_PIPELINE_PAUSED, []sideEffect{}, "", nil
}
switch pi.State {
case pps.PipelineState_PIPELINE_RUNNING:
return pi.State, []sideEffect{
CrashingMonitorSideEffect(sideEffectToggle_DOWN),
PipelineMonitorSideEffect(sideEffectToggle_UP),
// default: scale up if pipeline start hasn't propagated to the collection yet
// Note: mostly this should do nothing, as this runs several times per job
ScaleWorkersSideEffect(sideEffectToggle_UP),
}, "", nil
case pps.PipelineState_PIPELINE_STANDBY:
return pi.State, []sideEffect{
CrashingMonitorSideEffect(sideEffectToggle_DOWN),
// Make sure pipelineMonitor is running to pull it out of standby
PipelineMonitorSideEffect(sideEffectToggle_UP),
// default: scale down if standby hasn't propagated to kube RC yet
ScaleWorkersSideEffect(sideEffectToggle_DOWN),
}, "", nil
case pps.PipelineState_PIPELINE_CRASHING:
return pi.State, []sideEffect{
// start a monitor to poll k8s and update us when it goes into a running state
CrashingMonitorSideEffect(sideEffectToggle_UP),
PipelineMonitorSideEffect(sideEffectToggle_UP),
// Surprisingly, scaleUpPipeline() is necessary, in case a pipelines is
// quickly transitioned to CRASHING after coming out of STANDBY. Because the
// pipeline controller reads the current state of the pipeline after each
// event (to avoid getting backlogged), it might never actually see the
// pipeline in RUNNING. However, if the RC is never scaled up, the pipeline
// can never come out of CRASHING, so do it here in case it never happened.
//
// In general, CRASHING is actually almost identical to RUNNING (except for
// the monitorCrashing goro)
ScaleWorkersSideEffect(sideEffectToggle_UP),
}, "", nil
}
return 0, nil, "", errors.New("could not evaluate pipeline transition")
}
func (pc *pipelineController) apply(ctx context.Context, pi *pps.PipelineInfo, rc *v1.ReplicationController, target pps.PipelineState, sideEffects []sideEffect, reason string) error {
for _, s := range sideEffects {
if err := s.apply(ctx, pc, pi, rc); err != nil {
return errors.Wrapf(err, "apply side effect %s", s.String())
}
}
if target != pi.State {
return errors.EnsureStack(pc.psDriver.SetState(ctx, pi.SpecCommit, target, reason))
}
return nil
}
// rcIsFresh returns a boolean indicating whether rc has the right labels
// corresponding to pipelineInfo. If this returns false, it likely means the
// current RC is using e.g. an old spec commit or something.
func rcIsFresh(ctx context.Context, pi *pps.PipelineInfo, rc *v1.ReplicationController) bool {
if rc == nil {
log.Error(ctx, "RC is nil")
return false
}
expectedName := ppsutil.PipelineRcName(pi)
// establish current RC properties
rcName := rc.ObjectMeta.Name
rcPachVersion := rc.ObjectMeta.Annotations[pachVersionAnnotation]
rcAuthTokenHash := rc.ObjectMeta.Annotations[hashedAuthTokenAnnotation]
rcPipelineVersion := rc.ObjectMeta.Annotations[pipelineVersionAnnotation]
rcSpecCommit := rc.ObjectMeta.Annotations[pipelineSpecCommitAnnotation]
switch {
case rcPipelineVersion != strconv.FormatUint(pi.Version, 10):
log.Info(ctx, "pipeline version looks stale", zap.String("old", rcPipelineVersion), zap.Uint64("new", pi.Version))
return false
case rcSpecCommit != pi.SpecCommit.Id:
log.Info(ctx, "pipeline spec commit looks stale", zap.String("old", rcSpecCommit), zap.String("new", pi.SpecCommit.Id))
return false
case rcPachVersion != version.PrettyVersion():
log.Info(ctx, "pipeline is using stale pachd", zap.String("old", rcPachVersion), zap.String("new", version.PrettyVersion()))
return false
case rcName != expectedName:
log.Info(ctx, "pipeline has an unexpected (likely stale) name", zap.String("old", rcName), zap.String("new", expectedName))
return false
case rcAuthTokenHash != hashAuthToken(pi.AuthToken):
log.Info(ctx, "pipeline auth token is stale", zap.String("old", rcAuthTokenHash), zap.String("new", hashAuthToken(pi.AuthToken)))
return false
}
return true
}
// startPipelineMonitor spawns a monitorPipeline() goro for this pipeline (if
// one doesn't exist already), which manages standby and cron inputs, and
// updates the the pipeline state.
// Note: this is called by every run through step(), so must be idempotent
func (pc *pipelineController) startPipelineMonitor(ctx context.Context, pi *pps.PipelineInfo) {
if pc.monitorCancel == nil {
pc.monitorCancel = pc.startMonitor(ctx, pi)
}
}
func (pc *pipelineController) startCrashingPipelineMonitor(pi *pps.PipelineInfo) {
if pc.crashingMonitorCancel == nil {
pc.crashingMonitorCancel = pc.startCrashingMonitor(pc.ctx, pi)
}
}
func (pc *pipelineController) stopPipelineMonitor() {
if pc.monitorCancel != nil {
pc.monitorCancel()
pc.monitorCancel = nil
}
}
func (pc *pipelineController) stopCrashingPipelineMonitor() {
if pc.crashingMonitorCancel != nil {
pc.crashingMonitorCancel()
pc.crashingMonitorCancel = nil
}
}
// finishPipelineOutputCommits finishes any output commits of
// 'pipelineInfo.Pipeline' with an empty tree.
// TODO(msteffen) Note that if the pipeline has any jobs (which can happen if
// the user manually deletes the pipeline's RC, failing the pipeline, after it
// has created jobs) those will not be updated, but they should be FAILED
//
// Unlike other functions in this file, finishPipelineOutputCommits doesn't
// cause retries if it encounters an error. Currently. it's only called by step()
// in the case where pc's pipeline is already in FAILURE. If it returns an error in
// that case, the pps master will log the error and move on to the next pipeline
// event. This pipeline's output commits will stay open until another watch
// event arrives for the pipeline and finishPipelineOutputCommits is retried.
func (pc *pipelineController) finishPipelineOutputCommits(ctx context.Context, pi *pps.PipelineInfo) (retErr error) {
log.Info(ctx, "finishing output commits")
pachClient := pc.env.GetPachClient(ctx)
if span, _ctx := tracing.AddSpanToAnyExisting(ctx,
"/pps.Master/FinishPipelineOutputCommits", "project", pi.Pipeline.GetProject().GetName(), "pipeline", pi.Pipeline.GetName()); span != nil {
pachClient = pachClient.WithCtx(_ctx) // copy span back into pachClient
defer func() {
tracing.TagAnySpan(span, "err", fmt.Sprintf("%v", retErr))
tracing.FinishAnySpan(span)
}()
}
pachClient.SetAuthToken(pi.AuthToken)
c := client.NewCommit(pi.Pipeline.Project.GetName(), pi.Pipeline.Name, pi.Details.OutputBranch, "")
if err := pachClient.ListCommitF(c.Repo, c, nil, 0, false, func(commitInfo *pfs.CommitInfo) error {
return pachClient.StopJob(pi.Pipeline.Project.GetName(), pi.Pipeline.Name, commitInfo.Commit.Id)
}); err != nil {
if errutil.IsNotFoundError(err) {
return nil // already deleted
}
return errors.Wrapf(err, "could not finish output commits of pipeline %q", pi.Pipeline)
}
return nil
}
// scaleUpPipeline edits the RC associated with pc's pipeline & spins up the
// configured number of workers.
func (pc *pipelineController) scaleUpPipeline(ctx context.Context, pi *pps.PipelineInfo, oldRC *v1.ReplicationController) (retErr error) {
log.Debug(ctx, "ensuring correct k8s resources")
span, _ := tracing.AddSpanToAnyExisting(ctx,
"/pps.Master/ScaleUpPipeline", "project", pi.Pipeline.Project, "pipeline", pi.Pipeline.Name)
defer func() {
if retErr != nil {
log.Info(ctx, "PPS master: error scaling up", zap.Error(retErr))
}
tracing.TagAnySpan(span, "err", retErr)
tracing.FinishAnySpan(span)
}()
// Compute maximum parallelism
maxScale := int32(1)
if pi.Details.ParallelismSpec != nil && pi.Details.ParallelismSpec.Constant > 0 {
maxScale = int32(pi.Details.ParallelismSpec.Constant)
}
// update pipeline RC
return errors.EnsureStack(pc.iDriver.UpdateReplicationController(ctx, oldRC, func(rc *v1.ReplicationController) bool {
var curScale int32
if rc.Spec.Replicas != nil && *rc.Spec.Replicas > 0 {
curScale = *rc.Spec.Replicas
}
targetScale := func() int32 {
if !pi.Details.Autoscaling {
return maxScale // don't bother if Autoscaling is off
}
if curScale == 0 {
return 1 // make one pod to be the worker master & calculate tasks
}
// Master is scheduled; see if tasks have been calculated
var nTasks int32
// TODO: should this run through internal PPS service?
err := pc.env.GetPachClient(ctx).ListTask("pps", driver.TaskNamespace(pi), "", func(info *task.TaskInfo) error {
switch info.State {
case task.State_CLAIMED, task.State_RUNNING:
nTasks++
}
return nil
})
// Set parallelism
log.Debug(ctx, "beginning scale-up check", zap.Int32("currentTasks", nTasks), zap.Int32("currentScale", curScale))
switch {
case err != nil || nTasks == 0:
log.Info(ctx, "tasks remaining not known, possibly still being calculated", zap.Error(err))
return curScale // leave pipeline alone until until nTasks is available
case nTasks <= curScale:
log.Debug(ctx, "can't scale down without dropping work")
return curScale // can't scale down w/o dropping work
case nTasks <= maxScale:
return nTasks
default:
return maxScale
}
}()
if targetScale < maxScale {
// schedule another step in scaleUpInterval, to check the tasks again
go func() {
time.Sleep(pc.scaleUpInterval)
// Normally, it's necessary to acquire the mutex in step.pc.pcMgr and
// then read the latest pipelineController from pcMgr before calling
// Bump(), in order to avoid Bumping a dead pipelineController and
// dropping a Bump event. But in this case, we'd rather drop the Bump
// event. If this pipeline was recently updated, the new pipeline may
// not have autoscaling, or it may simply not make sense to trigger an
// update anymore.
if pc.ctx.Err() == nil {
pc.Bump(time.Time{}) // no ts, as it's not a new event
}
}()
}
if curScale == targetScale {
log.Debug(ctx, "pipeline is at desired scale", zap.Int32("scale", curScale))
return false // no changes necessary
}
// Update the # of replicas
log.Debug(ctx, "pipeline scaling", zap.Int32("currentScale", curScale), zap.Int32("targetScale", targetScale))
rc.Spec.Replicas = &targetScale
return true
}))
}
// scaleDownPipeline edits the RC associated with pc's pipeline & spins down the
// configured number of workers.
func (pc *pipelineController) scaleDownPipeline(ctx context.Context, pi *pps.PipelineInfo, rc *v1.ReplicationController) (retErr error) {
log.Debug(ctx, "scaling down workers")
span, _ := tracing.AddSpanToAnyExisting(ctx,
"/pps.Master/ScaleDownPipeline", "project", pi.Pipeline.Project, "pipeline", pi.Pipeline.Name)
defer func() {
if retErr != nil {
log.Info(ctx, "error scaling down", zap.Error(retErr))
}
tracing.TagAnySpan(span, "err", retErr)
tracing.FinishAnySpan(span)
}()
return errors.EnsureStack(pc.iDriver.UpdateReplicationController(ctx, rc, func(rc *v1.ReplicationController) bool {
if rc.Spec.Replicas != nil && *rc.Spec.Replicas == 0 {
return false // prior attempt succeeded
}
log.Debug(ctx, "scale down pipeline to 0 replicas")
rc.Spec.Replicas = &zero
return true
}))
}
// restartPipeline updates the RC/service associated with pc's pipeline.
// Note that restartPipeline only deletes rc if it's stale--a prior bug
// was that it would delete all of pc's resources, and then get stuck in a
// loop deleting and recreating pc's RC if the cluster was busy and
// the RC was taking too long to start.
func (pc *pipelineController) restartPipeline(ctx context.Context, pi *pps.PipelineInfo, rc *v1.ReplicationController) error {
if rc != nil && !rcIsFresh(ctx, pi, rc) {
// delete old RC, monitorPipeline goro, and worker service
if err := pc.deletePipelineResources(); err != nil {
return newRetriableError(err, "error deleting resources for restart")
}
}
// create up-to-date RC
if err := pc.iDriver.CreatePipelineResources(ctx, pi); err != nil {
return errors.Wrap(err, "error creating resources for restart")
}
return nil
}
// deletePipelineResources deletes the monitors, k8s RC and k8s services associated with pc's
// pipeline. It doesn't return a stepError, leaving retry behavior to the caller
func (pc *pipelineController) deletePipelineResources() (retErr error) {
// Cancel any running monitorPipeline call
pc.stopPipelineMonitor()
// Same for cancelCrashingMonitor
pc.stopCrashingPipelineMonitor()
return errors.EnsureStack(pc.iDriver.DeletePipelineResources(pc.ctx, pc.pipeline))
}
// Unlike other functions in this file, getRC takes responsibility for restarting
// pc's pipeline if it can't read the pipeline's RC (or if the RC is stale or
// redundant), and then returns an error to the caller to indicate that the
// caller shouldn't continue with other operations
func (pc *pipelineController) getRC(ctx context.Context, pi *pps.PipelineInfo) (rc *v1.ReplicationController, restart bool, retErr error) {
span, _ := tracing.AddSpanToAnyExisting(ctx,
"/pps.Master/GetRC", "project", pc.pipeline.GetProject().GetName(), "pipeline", pc.pipeline.GetName())
defer func(span opentracing.Span) {
tracing.TagAnySpan(span, "err", fmt.Sprintf("%v", retErr))
tracing.FinishAnySpan(span)
}(span)
// count error types separately, so that this only errors if the pipeline is
// stuck and not changing
var notFoundErrCount, unexpectedErrCount, staleErrCount, tooManyErrCount,
otherErrCount int
err := backoff.RetryNotify(func() error {
var err error
rcs, err := pc.iDriver.ReadReplicationController(pc.ctx, pi)
if err != nil && !errutil.IsNotFoundError(err) {
return errors.EnsureStack(err)
}
if len(rcs.Items) == 0 {
rc = nil
return errRCNotFound
}
rc = &rcs.Items[0]
switch {
case len(rcs.Items) > 1:
// select stale RC if possible, so that we delete it in restartPipeline
for i := range rcs.Items {
rc = &rcs.Items[i]
if !rcIsFresh(ctx, pi, rc) {
break
}
}
return errTooManyRCs
case !rcIsFresh(ctx, pi, rc):
return errStaleRC
default:
return nil
}
}, backoff.NewInfiniteBackOff(), func(err error, d time.Duration) error {
switch {
case errors.Is(err, errRCNotFound):
notFoundErrCount++
case errors.Is(err, errUnexpectedRC):
unexpectedErrCount++
case errors.Is(err, errTooManyRCs):
tooManyErrCount++
case errors.Is(err, errStaleRC):
staleErrCount++ // don't return immediately b/c RC might be changing
default:
otherErrCount++
}
errCount := max(notFoundErrCount, unexpectedErrCount, staleErrCount,
tooManyErrCount, otherErrCount)
if errCount >= maxErrCount {
invalidRCState := errors.Is(err, errTooManyRCs) || errors.Is(err, errStaleRC)
if invalidRCState {
restart = true
return errutil.ErrBreak
}
return err //return whatever the most recent error was
}
log.Info(ctx, "error retrieving RC; retrying", zap.Error(err), zap.Duration("retryAfter", d))
return nil
})
return rc, restart, err
}