refactor: replace strings.Replace with strings.ReplaceAll (#7660)

strings.ReplaceAll(s, old, new) is a wrapper function for
strings.Replace(s, old, new, -1). But strings.ReplaceAll is more
readable and removes the hardcoded -1.

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>

Co-authored-by: PFedak <pzfedak@gmail.com>

src/internal/cmdutil/cobra.go

@@ -334,9 +334,9 @@ func CreateAlias(cmd *cobra.Command, invocation string) *cobra.Command {
 			if cmd.Use == "" {
 				cur.Use = arg
 			} else {
-				cur.Use = strings.Replace(cmd.Use, "{{alias}}", arg, -1)
+				cur.Use = strings.ReplaceAll(cmd.Use, "{{alias}}", arg)
 			}
-			cur.Example = strings.Replace(cmd.Example, "{{alias}}", fmt.Sprintf("%s %s", os.Args[0], invocation), -1)
+			cur.Example = strings.ReplaceAll(cmd.Example, "{{alias}}", fmt.Sprintf("%s %s", os.Args[0], invocation))
 		} else {
 			cur.Use = arg
 		}

src/internal/collection/postgres_listener.go

@@ -322,7 +322,7 @@ type postgresListener struct {
 
 func NewPostgresListener(dsn string) PostgresListener {
 	// Apparently this is very important for lib/pq to work
-	dsn = strings.Replace(dsn, "statement_cache_mode=describe", "", -1)
+	dsn = strings.ReplaceAll(dsn, "statement_cache_mode=describe", "")
 	eg, _ := errgroup.WithContext(context.Background())
 
 	l := &postgresListener{

src/internal/ppsutil/util.go

@@ -53,7 +53,7 @@ func PipelineRcName(name string, version uint64) string {
 	// k8s won't allow RC names that contain upper-case letters
 	// or underscores
 	// TODO: deal with name collision
-	name = strings.Replace(name, "_", "-", -1)
+	name = strings.ReplaceAll(name, "_", "-")
 	return fmt.Sprintf("pipeline-%s-v%d", strings.ToLower(name), version)
 }
 

src/internal/pretty/pretty.go

@@ -13,8 +13,8 @@ import (
 
 // UnescapeHTML returns s with < and > unescaped.
 func UnescapeHTML(s string) string {
-	s = strings.Replace(s, "\\u003c", "<", -1)
-	s = strings.Replace(s, "\\u003e", ">", -1)
+	s = strings.ReplaceAll(s, "\\u003c", "<")
+	s = strings.ReplaceAll(s, "\\u003e", ">")
 	return s
 }
 

src/internal/uuid/uuid.go

@@ -30,12 +30,12 @@ func New() string {
 
 // NewWithoutDashes returns a new uuid without no "-".
 func NewWithoutDashes() string {
-	return strings.Replace(New(), "-", "", -1)
+	return strings.ReplaceAll(New(), "-", "")
 }
 
 // NewWithoutUnderscores returns a new uuid without no "_".
 func NewWithoutUnderscores() string {
-	return strings.Replace(New(), "_", "", -1)
+	return strings.ReplaceAll(New(), "_", "")
 }
 
 // IsUUIDWithoutDashes checks whether a string is a UUID without dashes