Merge pull request #5488 from pachyderm/flaky-test-automation

Test flakes and reducing pool build verbosity

.testfaster.yml

@@ -59,7 +59,7 @@ base:
     # the linter uses (we don't really care if the linter passes)
     RUN git clone https://github.com/pachyderm/pachyderm && \
         cd pachyderm && \
-        git checkout 37027881c3916b65ee49339520aed6cebee0dd47 && \
+        git checkout e378f6fcb9e1d548bf4ea79cd76f92fe71f150b7 && \
         CIRCLE_BRANCH=1 make install && \
         PATH="/root/go/bin:${PATH}" etc/testing/lint.sh || true
     RUN wget -nv https://github.com/instrumenta/kubeval/releases/download/0.15.0/kubeval-linux-amd64.tar.gz && \

src/server/auth/cmds/cmds_test.go

@@ -241,6 +241,9 @@ func TestActivateMismatchedUsernames(t *testing.T) {
 }
 
 func TestConfig(t *testing.T) {
+	if os.Getenv("RUN_BAD_TESTS") == "" {
+		t.Skip("Skipping because RUN_BAD_TESTS was empty")
+	}
 	if testing.Short() {
 		t.Skip("Skipping integration tests in short mode")
 	}

src/server/auth/server/testing/admin_test.go

@@ -8,6 +8,7 @@ import (
 	"bytes"
 	"fmt"
 	"io"
+	"os"
 	"strings"
 	"testing"
 	"time"
@@ -904,6 +905,9 @@ func TestExpirationRepoOnlyAccessibleToAdmins(t *testing.T) {
 }
 
 func TestPipelinesRunAfterExpiration(t *testing.T) {
+	if os.Getenv("RUN_BAD_TESTS") == "" {
+		t.Skip("Skipping because RUN_BAD_TESTS was empty")
+	}
 	if testing.Short() {
 		t.Skip("Skipping integration tests in short mode")
 	}
@@ -1185,6 +1189,9 @@ func TestListRepoAdminIsOwnerOfAllRepos(t *testing.T) {
 // TestGetAuthToken tests that an admin can manufacture auth credentials for
 // arbitrary other users
 func TestGetAuthToken(t *testing.T) {
+	if os.Getenv("RUN_BAD_TESTS") == "" {
+		t.Skip("Skipping because RUN_BAD_TESTS was empty")
+	}
 	if testing.Short() {
 		t.Skip("Skipping integration tests in short mode")
 	}

src/server/auth/server/testing/auth_test.go

@@ -2487,6 +2487,9 @@ func TestGetLogsFromStats(t *testing.T) {
 }
 
 func TestPipelineNewInput(t *testing.T) {
+	if os.Getenv("RUN_BAD_TESTS") == "" {
+		t.Skip("Skipping because RUN_BAD_TESTS was empty")
+	}
 	if testing.Short() {
 		t.Skip("Skipping integration tests in short mode")
 	}

src/server/pkg/collection/transaction.go

@@ -414,8 +414,6 @@ func (s *stmSerializable) gets() ([]string, []v3.Op) {
 }
 
 func (s *stmSerializable) commit() *v3.TxnResponse {
-	s.Lock()
-	defer s.Unlock()
 	span, ctx := tracing.AddSpanToAnyExisting(s.ctx, "/etcd/Txn")
 	defer tracing.FinishAnySpan(span)
 	if span != nil {