Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-2256] Backport hint fixes to 2.10 #10012

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

robert-uhl
Copy link
Contributor

Reworked paging and hints. Added a plethora of tests against a testing Loki instance. Worked with @pleeko to test expected vs. actual results.

Reworked paging and hints. Added a plethora of tests against a testing
Loki instance. Worked with @pleeko to test expected vs. actual results.
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 76.71233% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 58.31%. Comparing base (6c0d400) to head (5c7086b).

Files Patch % Lines
src/server/logs/cmds/cmds.go 16.66% 10 Missing ⚠️
src/server/logs/logs.go 82.14% 5 Missing ⚠️
src/server/logs/query.go 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           2.10.x   #10012      +/-   ##
==========================================
+ Coverage   58.19%   58.31%   +0.12%     
==========================================
  Files         614      614              
  Lines       75590    75604      +14     
==========================================
+ Hits        43992    44091      +99     
+ Misses      31046    30958      -88     
- Partials      552      555       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robert-uhl robert-uhl marked this pull request as ready for review May 2, 2024 15:24
@robert-uhl robert-uhl requested review from a team as code owners May 2, 2024 15:24
@robert-uhl robert-uhl requested review from emmajsadams and zmajeed and removed request for a team May 2, 2024 15:24
@robert-uhl robert-uhl merged commit 956693a into 2.10.x May 2, 2024
22 checks passed
@robert-uhl robert-uhl deleted the rau/core-2256-backport branch May 2, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants