[PFS-242] Fix issues that prevent gocdk from being disabled. #10013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that the `default` function in Helm doesn't work as expected for `boolean` types (which you would expect it to work for at the bare minimum), but this is because of a technicality in Helm's design: helm/helm#3308 Also, we had to add code to handle legacy storage configuration in the new StorageEnv code for the storage service.
FahadBSyed
changed the title
Zhang-Muyang
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the
defaultfunction in Helm doesn't work as expected forbooleantypes (which you would expect it to work for at the bare minimum), but this is because of a technicality in Helm's design: helm/helm#3308Also, we had to add code to handle legacy storage configuration in the new StorageEnv code for the storage service.