[2.10.x] Unignore the pulumi code and add a test for it #10020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue with a dependency of Pulumi that prevented us from building with Bazel. That is fixed, or at least worked around cleanly: bazelbuild/rules_go#3799 (comment) With the workarounds, this now builds OK, so I've unignored it and added a BUILD file. There was also an issue where it generates invalid helm values. I fixed that bug and added a test.
davidfluck-hpe
approved these changes
May 3, 2024
jrockway
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.10.x #10020 +/- ##
==========================================
- Coverage 58.30% 58.28% -0.03%
==========================================
Files 614 619 +5
Lines 75613 76069 +456
==========================================
+ Hits 44085 44334 +249
- Misses 30981 31187 +206
- Partials 547 548 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with a dependency of Pulumi that prevented us from building with Bazel. That is fixed, or at least worked around cleanly: bazelbuild/rules_go#3799 (comment)
With the workarounds, this now builds OK, so I've unignored it and added a BUILD file.
There was also an issue where it generates invalid helm values. I fixed that bug and added a test.
Backports #10017