[Backport 2.10] Fixing Duplicate Pipeline Versions [CORE-2252] (#10024) #10038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acohen4
changed the title
Summary: This change adds a migration step to 2.10 that detects whether pipeline versions with colliding version numbers exist. If detected, the migration proceeds to renumber all of the pipeline versions for the offending pipelines, updates the corresponding Job objects in the collections.jobs table, and finally adds a UNIQUE index onto the Pipelines table so that we prevent the database from entering a bad state in the future. TODO - [x] fix for issue - [x] tests infra - [x] handle proto versions - [x] test completion --------- Co-authored-by: Zartaj Majeed <zartaj.majeed@hpe.com> Co-authored-by: Robert A. Uhl <robert.uhl@hpe.com> Co-authored-by: Alon Cohen <acohen4@users.noreply.github.com> Co-authored-by: Zartaj Majeed <zmajeed@users.noreply.github.com>
acohen4
force-pushed
the
acohen4/2_10-fix-dup-pips
branch
from
9025399
to
30fc62f
Compare
robert-uhl
approved these changes
May 8, 2024
jrockway
approved these changes
May 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.10.x #10038 +/- ##
==========================================
- Coverage 58.11% 57.91% -0.20%
==========================================
Files 619 620 +1
Lines 76009 76178 +169
==========================================
- Hits 44174 44121 -53
- Misses 31287 31516 +229
+ Partials 548 541 -7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change adds a migration step to 2.10 that detects whether pipeline versions with colliding version numbers exist. If detected, the migration proceeds to renumber all of the pipeline versions for the offending pipelines, updates the corresponding Job objects in the collections.jobs table, and finally adds a UNIQUE index onto the Pipelines table so that we prevent the database from entering a bad state in the future.
TODO